Closed
Bug 1151202
Opened 10 years ago
Closed 10 years ago
libstagefright: Compilation with musl libc: sys/cdefs.h: No such file or directory
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: felix.janda, Assigned: felix.janda)
Details
Attachments
(1 file)
|
762 bytes,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
The compilation of media/libstagefright fails on musl libc (http://musl-libc.org) based linux systems because media/libstagefright/system/core/include/cutils/properties.h tries to include <sys/cdefs.h>, which is not provided by musl libc.
cutils/properties.h is from android platform/system/core and it intends to include the bionic libc internal header <sys/cdefs.h> in order to get e.g. the defines __BIONIC_FORTIFY.
Therefore including <sys/cdefs.h> is only necessary for android and for android it is automatically included by the POSIX header <sys/types.h>. So the include <sys/cdefs.h> can be safely replaced by <sys/types.h>.
Attachment #8588302 -
Flags: review?(wkocher)
Comment on attachment 8588302 [details] [diff] [review]
Proposed patch
I'm not a reviewer for this, sorry.
Attachment #8588302 -
Flags: review?(wkocher) → review?(cpearce)
|
||
Updated•10 years ago
|
Attachment #8588302 -
Flags: review?(cpearce) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
Could someone do a try push for me? (I don't have commit access.)
|
||
Comment 3•10 years ago
|
||
Assignee: nobody → felix.janda
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•