1151252 - In-Content Preferences → Content → Default font: all entries are blank, list too narrow

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[[:Aleksej]]

Attachment: Screenshot of 2015-04-04-03-02-18-mozilla-central-firefox-40.0a1.en-US.linux-x86_64

b firefox-38.0b1.ru.linux64
g 2015-01-01-03-02-14-mozilla-central-firefox-37.0a1.en-US.linux-x86_64
g 2015-03-03-03-02-30-mozilla-central-firefox-39.0a1.en-US.linux-x86_64 0b3c520002ad
b 2015-03-04-03-02-31-mozilla-central-firefox-39.0a1.ru.linux-x86_64 c5b90c003be8
b 2015-04-04-03-02-18-mozilla-central-firefox-40.0a1.en-US.linux-x86_64

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0b3c520002ad&tochange=c5b90c003be8

bug 1136670 "InContent Prefs - Implement alignment according to spec"?

Comment 1

[[:Aleksej]]

Attachment: Screenshot of the dropdown list made of blank entries (the light-blue one below is under the mouse pointer).

Comment 2

[Richard Marti (:Paenglab)]

Attachment: bug1151252.patch

Let the content wrap when the page is to small like it's done in General page.

Comment 3

[[:Aleksej]]

(In reply to Richard Marti (:Paenglab) from comment #2)
> Created attachment 8588432 [details] [diff] [review]
> bug1151252.patch
> 
> Let the content wrap when the page is to small like it's done in General
> page.

Sorry about shrinking the window for the screenshot, but the page is probably not too small.  The resolution is 1920x1080.

Comment 4

[Richard Marti (:Paenglab)]

Then attach a screenshot with your normal resolution.

Comment 5

[[:Aleksej]]

Attachment: Screenshot of 2015-04-05-03-02-38, 1920x1080

Comment 6

[[:Aleksej]]

Attachment: Screenshot of 2015-04-04-03-02-18, Advanced window: all font names fit in it

$ fc-list|egrep -o ": [^:]+,"|egrep -o "[^:,]+"|wc -L
29

So the longest font name (which I can see without the penultimate command) is about 28 characters long.

Comment 7

[Richard Marti (:Paenglab)]

Aleksej, it looks, you have set a big font size. My patch should fix your problem. But the page width is set to 800px and with your font this isn't enough.

Jared, what do you think, should this page width be set with 'ch' or something similar to have a relative width?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8588432 [details] [diff] [review]
bug1151252.patch

I think we might want to backout the re-layout part of bug 1136670 and give UX more time to think of a UI that will scale better.

Comment 9

[:Gijs (he/him)]

Attachment: back out content part of the restyle of about:preferences,

This backs out the change from bug 1013695 and the content part of bug 1136670.

Comment 10

[:Gijs (he/him)]

Attachment: back out content part of the restyle of about:preferences,

Now keeping the size label adjustment.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8589104 [details] [diff] [review]
back out content part of the restyle of about:preferences,

Review of attachment 8589104 [details] [diff] [review]:
-----------------------------------------------------------------

We'll want to re-apply the changes from bug 1013695 on top of the backout, since the issue still existed before the change in layouts.

Comment 12

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/25325c131f48

Comment 13

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/25325c131f48

Comment 14

[:Gijs (he/him)]

Comment on attachment 8589106 [details] [diff] [review]
back out content part of the restyle of about:preferences,

Approval Request Comment
[Feature/regressing bug #]: bug 1136670
[User impact if declined]: can't easily change font names in preferences depending on the locale / font size
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: very low, basically a targeted backout of the bits that regressed this
[String/UUID change made/needed]: nope

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8589106 [details] [diff] [review]
back out content part of the restyle of about:preferences,

Should be in 38 beta 3.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f90e5f251eec

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fa50c9c02b3c

Comment 18

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 40.0a1 (buildID: 20150427030207), latest Aurora 39.0a2 (buildID: 20150427004010) and Firefox 38 Beta 8 (buildID: 20150426174329).