1151329 - Autophone - properly handle local build urls

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

utils.get_remote_text does not properly handle local file:// urls. First, it will not even attempt to read the file content due to the conditional on the request's code. Second, if the url is a simple local path without a file scheme, urllib2.urlopen will fail due to the unknown scheme. This is a regression from bug 1133580.

In autophone.new_job when checking if the build is from a supported repository for the device and test, it uses a check if the repo is contained in the build url. This doesn't work for local builds where the local file path does not match the pattern used on ftp.mozilla.org. We should instead uses the repo returned from the build.txt file.

In builds.BuildLocation.find_builds_by_directory we should the returned builds for local paths include the file scheme.

I've tested this with local builds and remote builds using the various date selections.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: pr 21

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 8588435 [details] [review]
pr 21

Looks good.

Consider handling unexpected (non-http and non-file) schemes with an explicit error.

Comment 3

[Bob Clary [:bc] (inactive)]

Comment on attachment 8588435 [details] [review]
pr 21

Added an exception if utils.get_remote_text's url does not specify a scheme and fixed the find_builds_by_directory urlparse.urljoin to use file: instead of file.

Comment 4

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/660a643c357d0b6ae4edbf4482eabfbc1f3b3f8a