1151343 - "Top Sites" items have improper accessibility grouping

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Boris Dušek]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_2) AppleWebKit/600.4.10 (KHTML, like Gecko) Version/8.0.4 Safari/600.4.10

Steps to reproduce:

1. Opened Firefox for iOS
2. Opened Tab Tray (button in top right with tab count)
3. Added new tab (Add button in top right)
4. Turned on VoiceOver (e.g. triple-tap home button if you have accessibility shortcut set to VoiceOver (Settings.app > General > Accessibility > Accessibility Shortcut > VoiceOver))
5. Touch the thumbnail of any webpage shown
6. Touch the table cell-like items at the bottom


Actual results:

5. There is no accessibility element at that position (only the title beneath the thumbnail is accessibility element)
6. Page title and Page URL are 2 separate items


Expected results:

5. The combo of webpage thumbnail and its title is one big accessibility element and announces the page title.

6. Page title and page URL are one big accessibility element and announce title followed by the url (separated by comma to give pause in speech and delimiting in braille).

In both cases, this makes touch exploration experience much more comfortable for both a blind and a low-vision VoiceOver user.

Comment 1

[Boris Dušek]

https://github.com/mozilla/firefox-ios/pull/307

Comment 2

[Aaron Train [:aaronmt]]

Thanks. I have CC'ed Brian for review.

Comment 3

[Boris Dušek]

Just tested that this also enables Switch Control on the cells. Without this, SC users would not be able to use the Top Sites panel (with the exception of clicking items that are visible, i.e. ~ first 6 items).

Comment 4

[Boris Dušek]

(In reply to Aaron Train [:aaronmt] from comment #2)
> Thanks. I have CC'ed Brian for review.

Aaron, shall I CC Brian automatically on accessibility issues? CC you too?

Comment 5

[Aaron Train [:aaronmt]]

(In reply to Boris Dušek from comment #4)
> (In reply to Aaron Train [:aaronmt] from comment #2)
> > Thanks. I have CC'ed Brian for review.
> 
> Aaron, shall I CC Brian automatically on accessibility issues? CC you too?

Check git blame on the files affected. I see all bugs in this component (maybe they do too, hopefully?) Thanks for asking though.

Comment 6

[Brian Nicholson (:bnicholson)]

Attachment: Pull request

Comment 7

[Brian Nicholson (:bnicholson)]

(In reply to Boris Dušek from comment #4)
> Aaron, shall I CC Brian automatically on accessibility issues? CC you too?

Thanks for the pull request! The usual Bugzilla protocol is the following:
1) Add the URL of the pull request as an attachment
2 [review]) Flag review? for one of the iOS peers (me, st3fan, wesj, nalexander, etc.)

That'll add it to our queue so it doesn't get overlooked. Apologies for the silly system and all of the redundancies.

Comment 8

[Brian Nicholson (:bnicholson)]

(In reply to Brian Nicholson (:bnicholson) from comment #7)
> 2 [review]) Flag review? for one of the iOS peers (me, st3fan, wesj,
> nalexander, etc.)

Heh, please ignore the [review] link from this comment after the 2. Bugzilla was trying to be clever.