Closed Bug 1151353 Opened 5 years ago Closed 5 years ago

Selected search engine not highlighted in the search engine picker

Categories

(Firefox for iOS :: Browser, defect)

ARM
iOS 8
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: sachin.irukula, Unassigned)

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
nalexander
: review+
Details | Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_2) AppleWebKit/600.4.10 (KHTML, like Gecko) Version/8.0.4 Safari/600.4.10

Steps to reproduce:

Settings -> Search -> <search engine selected>


Actual results:

List of search engines is shown but the selected search engine is not highlighted.


Expected results:

Selected search engine is should have been highlighted.
Code to fix the issue https://github.com/mozilla/firefox-ios/pull/305
Thanks. I've CC'ed Nick for review.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: All → iOS 8
Hardware: All → ARM
Attached file Pull Request
Attachment #8589652 - Flags: review?(nalexander)
Comment on attachment 8589652 [details] [review]
Pull Request

Use the UITableViewCell's accessoryView to do this, like in http://stackoverflow.com/a/18001814.

The controller returns as soon as you select (IIRC), so you can just set the accessoryView once during the cellForRow:.
Attachment #8589652 - Flags: review?(nalexander) → review-
Comment on attachment 8589652 [details] [review]
Pull Request

Made changes based on the SO link given by alexander.
Attachment #8589652 - Flags: review- → review?
Attachment #8589652 - Flags: review? → review?(nalexander)
You need to log in before you can comment on or make changes to this bug.