Closed
Bug 1151353
Opened 9 years ago
Closed 9 years ago
Selected search engine not highlighted in the search engine picker
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sachin.irukula, Unassigned)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_2) AppleWebKit/600.4.10 (KHTML, like Gecko) Version/8.0.4 Safari/600.4.10 Steps to reproduce: Settings -> Search -> <search engine selected> Actual results: List of search engines is shown but the selected search engine is not highlighted. Expected results: Selected search engine is should have been highlighted.
|
Reporter | |
Comment 1•9 years ago
|
||
Code to fix the issue https://github.com/mozilla/firefox-ios/pull/305
|
||
Comment 2•9 years ago
|
||
Thanks. I've CC'ed Nick for review.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: All → iOS 8
Hardware: All → ARM
|
|
Reporter | |
Comment 3•9 years ago
|
||
Attachment #8589652 -
Flags: review?(nalexander)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8589652 [details] [review] Pull Request Use the UITableViewCell's accessoryView to do this, like in http://stackoverflow.com/a/18001814. The controller returns as soon as you select (IIRC), so you can just set the accessoryView once during the cellForRow:.
Attachment #8589652 -
Flags: review?(nalexander) → review-
|
|
Reporter | |
Comment 5•9 years ago
|
||
Comment on attachment 8589652 [details] [review] Pull Request Made changes based on the SO link given by alexander.
Attachment #8589652 -
Flags: review- → review?
|
|
Reporter | |
Updated•9 years ago
|
Attachment #8589652 -
Flags: review? → review?(nalexander)
|
|
||
Updated•9 years ago
|
Attachment #8589652 -
Flags: review?(nalexander) → review+
|
|
||
Comment 6•9 years ago
|
||
https://github.com/mozilla/firefox-ios/commit/510f27b187e331f3ef79eca4029245bf3659fc99
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•