1151484 - NPE at org.mozilla.gecko.reading.ReadingListSyncAdapter.onPerformSync

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Reading List Sync, defect)

Description

[:Margaret Leibovic]

E/FxReadingList(21147): java.lang.NullPointerException
E/FxReadingList(21147): 	at org.mozilla.gecko.reading.ReadingListSyncAdapter.onPerformSync(ReadingListSyncAdapter.java:263)
E/FxReadingList(21147): 	at android.content.AbstractThreadedSyncAdapter$SyncThread.run(AbstractThreadedSyncAdapter.java:259)

Comment 1

[Richard Newman [:rnewman]]

Ah. latch.poll returns null on timeout. Easy fix.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Pull request

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8588636 [details] [review]
Pull request

Aye, sorry to miss it.

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/ca85eda44904

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8588636 [details] [review]
Pull request

Approval Request Comment
[Feature/regressing bug #]:
  Error handling in syncadapter.

[User impact if declined]:
  In timeout situations, an error will be dumped to the system log and sync scheduling will be affected.

[Describe test coverage new/current, TreeHerder]:
  None.

[Risks and why]: 
  Low risk: the bug is that a default value of ERROR is being overwritten by null in some circumstances. This sets it back to ERROR in those cases.

[String/UUID change made/needed]:
  None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca85eda44904

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Should be in 38 beta 4.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a5af953eceb9

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8a734418a22e