1151497 - Web site from RSS feed not rendered correctly (due to noscript tags) - tab part

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Nomis101]

Attachment: screenshot of the issue

Bug 662907 fixed the noscript tag issue for rss feeds for the message pane, but not for tab. So, this is about fixing the issue in the tab. I found this while testing TB38b1, which will be the next ESR. So, it would be nice to get this fixed in TB38.

Steps to Reproduce:
1. Subscribe to feed http://www.heise.de/newsticker/heise-atom.xml
2. Open any post from that feed in a new tab.

Actual Results:  
Page from RSS feed isn't rendered properly when opened in TB. The top and right frame contain html code. 


I've included the screenshot from :JoeS1, but for me on OS X it looks the same. I see this issue too on feeds other than www.heise.de. It is fixed in the message pane and a workaround is described in this post: https://hitco.at/blog/mozilla-thunderbird-heise-rss-feed-korrekt-darstellen/

Comment 1

[Joe Sabash [:JoeS1]]

I'm quite sure that this was fixed in tab rendering in a previous bug.
But even with Total Message installed, I still see this bug.
Took the liberty to cc you alta88, your opinion is needed here.

Comment 2

[alta88]

Attachment: feedTab.patch

this patch works for messagepane loads in 3pane folder tab, 3pane message tab, and the standalone message window.  someone else will have to drive it from here.

Comment 3

[Nomis101]

Thanks for the patch. I have tested this one with a TB38 build and can confirm, that it will fix the issue in the message tab and the standalone window. But the feed looks different in the message pane.

Comment 4

[Kent James (:rkent)]

(In reply to Nomis101 from comment #3)
> But the feed looks different in the message pane.

Does that mean that you think that the patch is a bad idea?

I tried to reproduce this problem and could not. Is it still there?

Comment 5

[Joe Sabash [:JoeS1]]

Yes, it's still there, but only some feeds, and you must view as a webpage
http://www.heise.de/newsticker/heise-atom.xml demonstrates the problem.
It's a definite improvement, so we should take the patch IMO

Comment 6

[Kent James (:rkent)]

I've looked at posts from http://www.heise.de/newsticker/heise-atom.xml in a tab, I see the full web page, looks fine. So I am not reproducing.

Comment 7

[Joe Sabash [:JoeS1]]

(In reply to Kent James (:rkent) from comment #6)
> I've looked at posts from http://www.heise.de/newsticker/heise-atom.xml in a
> tab, I see the full web page, looks fine. So I am not reproducing.

Neither am I, as i am 73 years old. But as for the bug, I see it every time reliably.

Comment 8

[Nomis101]

I also still see it (in TB 38b3).


(In reply to Kent James (:rkent) from comment #4)
> (In reply to Nomis101 from comment #3)
> > But the feed looks different in the message pane.
> 
> Does that mean that you think that the patch is a bad idea?
No, sorry, I was wrong. I tested today again with a build with and without this patch. And the patch works fine. The feed looks the same in the message pane in both builds (so, I think it should look like this). Therefore, I think the patch is a good idea. Is it OK if I set it for review?

Comment 9

[Kent James (:rkent)]

Yes, set for review. I was hoping to help move this forward but I cannot reproduce which limits me.

Comment 10

[Kent James (:rkent)]

Magnus, this is currently set as a Thunderbird 38 blocker, but I cannot reproduce this. Can you attempt the review? Can you reproduce this?

Comment 11

[Kent James (:rkent)]

We are not making progress on this, and it is not critical enough to block release.

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 8590016 [details] [diff] [review]
feedTab.patch

Review of attachment 8590016 [details] [diff] [review]:
-----------------------------------------------------------------

Yes this looks fine. r=mkmelin

Comment 13

[Magnus Melin [:mkmelin]]

Attachment: feedtab-tests.patch

mozmill test to prove it works

Comment 14

[Magnus Melin [:mkmelin]]

try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=43c6f07dad76

Comment 15

[Magnus Melin [:mkmelin]]

Try shows no new errors.

Comment 16

[alta88]

Comment on attachment 8622001 [details] [diff] [review]
feedtab-tests.patch

Review of attachment 8622001 [details] [diff] [review]:
-----------------------------------------------------------------

looks good.  this bug manifests only if javascript.enabled is true.  although that is the default, and it's not honored by content policy when setting javascript on the docShell, it matters elsewhere.  perhaps it might be useful to set it in the test explicitly for future reference.

Comment 17

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/e769c32b3fb7
https://hg.mozilla.org/comm-central/rev/c2fb477b2e17
-> FIXED

Comment 18

[Magnus Melin [:mkmelin]]

Comment on attachment 8590016 [details] [diff] [review]
feedTab.patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: <noscript> content shown in tabbed feed content

We should uplift this after some trunk baking.

Comment 19

[Kent James (:rkent)]

http://hg.mozilla.org/releases/comm-aurora/rev/8d1237f05828
http://hg.mozilla.org/releases/comm-aurora/rev/338c457d22fa

Comment 20

[Kent James (:rkent)]

Comment on attachment 8622001 [details] [diff] [review]
feedtab-tests.patch

http://hg.mozilla.org/releases/comm-esr38/rev/c29b2def0b48

Comment 21

[Kent James (:rkent)]

Comment on attachment 8590016 [details] [diff] [review]
feedTab.patch

http://hg.mozilla.org/releases/comm-esr38/rev/e7d0e7c36518