Closed Bug 1151538 Opened 11 years ago Closed 11 years ago

Run Tabzilla translation bar action on pages without Google Analytics

Categories

(www.mozilla.org :: Pages & Content, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: freaktechnik, Assigned: freaktechnik)

Details

(Whiteboard: [kb=1712692])

Attachments

(1 external file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0 Build ID: 20150402143158 Steps to reproduce: Embed tabzilla on a multilingual page with the translation bar enabled but don't add Google Analytics to the page. See for example http://lab.humanoids.be/tabzilla-demo/?lang=fr and set the lang argument to a language you don't have in your content languages list and make sure it contains en, de or fr, so you get the translation bar. Then click on the "Yes" option, which should redirect to the matching page. Actual results: The infobar hides and nothing else happens. Expected results: The infobar should hide and get redirected to the page with the correct language. You can see this result on my testpage by adding &gaq=true to the URL, which inserts a minimal _gaq object into the page to make the bar work as expected.
Attached file pullrequest —
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/e365a04e4de23d1faf1e2d5ddeb93d480bf33893 Fix Bug 1151538 - Execute callback in tabzilla when GA isn't defined https://github.com/mozilla/bedrock/commit/3e153043c37018e2722f0514b7f5da2b304ce2aa Merge pull request #2895 from freaktechnik/Bug-1151538 Fix Bug 1151538 - Execute callback in tabzilla when GA isn't defined
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee: nobody → zm.redaktion
Whiteboard: [kb=1712692]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: