115160 - [mozTXTToHTMLConv] Optimize to speed up message display of messages with lots of links

Status: NEW

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

If you display a message with lots of links, MoxTxtToHTMLConv.cpp slows us down
a lot, copies data around excessively, allocates memory when it doesn't need to,
etc. I have a 440K spam message that takes several seconds to display, bloats
memory by 17MB or so, and leaks a lot of memory as well. So I'm going to try to
optimize this file to see if that fixes some of the bloat.

Comment 1

[Ben Bucksch (:BenB)]

Thanks for tuning the class.
Please make sure that you don't change the logic (intentionally or accidentally).
For the record: I take no responsibility for leaks introduced by char*s - that
wasn't me.

Comment 2

[David :Bienvenu]

Some test cases would help.

Comment 3

[Ben Bucksch (:BenB)]

Here you are: bug 116842.

Comment 4

[David :Bienvenu]

I don't see how this is going to happen at this point - recommend nsbeta1-

Comment 5

[David :Bienvenu]

Attachment: streamconv diffs

this is for posterity since I've given up on getting this in to 1.0, and
hopefully we'll rewrite this all later.

Comment 6

[David :Bienvenu]

Attachment: mime part of diffs

mime part of diffs. The attached patches all work and avoid memory allocations
in most cases - clients that used pass in unicode now convert the data to utf8
(though usually they started with utf8 with they 0 byte extended to unicode...)
I haven't attached the address book diffs - address book has started using
ScanTxt and I just got tired of all the conflicts

Comment 7

[Ludovic Hirlimann [:Usul]]

I have no idea how much this would cost engineering wise - but would be nice to have I think for the users experience.

Comment 8

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Perhaps target milestone should be updated? (Mozilla 1.2 Alpha seems ancient, just like some other js bugs currently out there. ;-) )

Comment 11

[Ludovic Hirlimann [:Usul]]

David any idea how much this would cost time wise to land ?

Comment 12

[David :Bienvenu]

(In reply to comment #11)
> David any idea how much this would cost time wise to land ?

It all needs to be looked at again - the string api's have changed, and the patch has bit-rotted quite a bit. Plus, we really should have some idea of how much of a performance win this would be, so we can consider the risk-reward.

Comment 13

[Ludovic Hirlimann [:Usul]]

Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.