1151646 - indexedDB::::CancelableRunnableWrapper::Cancel releases CCed objects after worker CC is shut down

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Andrew McCreight [:mccr8]]

I came across a few of these.  It looks like there was an IDB runnable that is releasing a DETH, but it is late enough in shutdown that the CC is gone.

https://crash-stats.mozilla.com/report/index/d7968201-b10e-4c9d-a1a1-567cd2150401#allthreads
https://crash-stats.mozilla.com/report/index/65738f58-194c-4bf6-9b9b-f19ac2150401
https://crash-stats.mozilla.com/report/index/5192ba6f-1389-4daf-97a0-8fabe2150401

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

I think this is all we need to do.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Cleanup, v1

This isn't stcitly needed for this bug but while I was looking here I noticed that the runtime-private stuff has grown a few too many warts over the years. This cleans it up a little. No changes to behavior.

And the IDBFactory change was a silly assertion failure fix.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/736c8f8f8c9b
https://hg.mozilla.org/integration/mozilla-inbound/rev/d225c07cf671

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/40cbdbbf2a26

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/736c8f8f8c9b
https://hg.mozilla.org/mozilla-central/rev/d225c07cf671
https://hg.mozilla.org/mozilla-central/rev/40cbdbbf2a26