1151665 - [EME] Add missing ^headers^ files to tests

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Some EME tests are missing ^headers^ files matching mp4 and m4s fragments, which could cause cache issues with the test server.
It might be the cause of some intermittent test failures (e.g. bug 1120741) as the server would sometimes feed the wrong contents.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1151665-eme-test-headers-p1-script.patch

Updated make-headers.sh to generate ^headers^ files for m4s fragments.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1151665-eme-test-headers-p2-headers.patch

Added missing ^headers^ for EME tests.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd7b6fd512e5

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a6460ccdc532
https://hg.mozilla.org/integration/mozilla-inbound/rev/b80d9840417a

Comment 5

[Carsten Book [:Tomcat]]

sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=5e4ea3189ff7 seems one of this changes caused frequent test failures like:

https://treeherder.mozilla.org/logviewer.html#?job_id=8536619&repo=mozilla-inbound

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I don't believe these ^header^ files are the cause of already-known intermittent failures, in fact they could only help remove some of them.

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

It seems unlikely that this change cause this orange spike as the changes here work around a bug in Firefox's network cache and so should actually make our orange rate go *down*.

Also, I only see one failure logged in bug 1148844 in the time period where this changeset was landed. Where are the other failures logged? Why do failures of test_eme_persistent_sessions not appear in bug 1148844?

Are the failures only on linux-e10s-m3? Without failures logged it's impossible for us to tell. If it's an e10s only failure, we should just disable the test in e10s, as e10s EME support was only enabled over the weekend.

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Apologies to cbook and Tomcat, it looks like adding these ^headers^ does exacerbate test_eme_persistent_sessions failures:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff7fcce15843
Very strange! Might be a timing issue?

Anyway later patches help bring these issues down again:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=48477eca32d6

So I will reorder patches so that they hopefully make more sense (while not hiding real code issues)...

Comment 9

[Chris Peterson [:cpeterson]]

Gerald, cpearce: should we uplift these test changes to Beta 38?

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

My apologies to tomcat as well.

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Chris Peterson [:cpeterson] from comment #9)
> Gerald, cpearce: should we uplift these test changes to Beta 38?

This will probably just be a test-only change, so I think at this stage we can assume it doesn't need uplifting.

Comment 12

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Trying with patch from bug 1154133:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=19326a3604ff

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0828107f887
https://hg.mozilla.org/integration/mozilla-inbound/rev/b385aa775aef

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0828107f887
https://hg.mozilla.org/mozilla-central/rev/b385aa775aef