1151684 - Assertion failure: "Unprocessed justification gaps", with "text-align: justify true;"

Status: RESOLVED INCOMPLETE

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: applyState.mGaps.mHandled == applyState.mGaps.mCount (Unprocessed justification gaps), at layout/generic/nsLineLayout.cpp:3131

The assertion was added in https://hg.mozilla.org/mozilla-central/rev/8fd4e3a06f17 (bug 1063857).

The extra text-align value was added in bug 929991. (For the state of Gecko vs state of the spec, see bug 929991 comment 26.)

Comment 1

[Jesse Ruderman]

To reproduce you need to set the pref:
  user_pref("layout.css.text-align-true-value.enabled", true);

Comment 2

[Jesse Ruderman]

Attachment: stack

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

So what should happen when text-align is "justify true"? Should "true" just be ignored? Or probably text should have negative spaces inside?

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

I meant, if the remaining isize is negative, should we add negative spaces inside text to make it really "justify"? Or just act like normal and ignore "true"?

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: another testcase

Comment 6

[Mats Palmgren (inactive)]

The spec changed after we implemented 'true' on 'text-align'.  I suspect
that we shouldn't implement <overflow-position> at all on text-align[-last],
only on the new properties in the css-align spec, but we should ask on
www-style@ to confirm this before starting to remove/change the code.

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Well, it doesn't seem that this syntax is ever included in the spec. dbaron and roc were failed to convince the editor that this should be added to the spec. Hence the truth is that the spec didn't changed because it just had not changed for this at all.

Therefore, in a forseeable future, I guess we won't enable this pref by default. Hence it's probably fine to just leave this bug as-is currenlty, and see if there will be any progress on make it speced.

Comment 8

[Andrei Purice]

Hey Jesse,
Can you still reproduce this issue or should we close it?

Comment 9

[Andrei Purice]

Marking this as Resolved > Incomplete as per reporter's lack of response.
If anyone can still reproduce this issue re-open it or file a new bug.