Closed Bug 1151745 Opened 9 years ago Closed 9 years ago

add ui to minimise steps required to move bugs between products

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Product:
bugzilla.mozilla.org
Component:
User Interface
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

References

Details

User Story

the high level flow should look like:
- click 'find' button next to product select in edit mode only
- show the product/component search field
- when the user selects the component change the selected product
- when the selected product is changed (either via search or directly):
  - xhr load components, versions, milestones, and security groups
  - preselect component if change initiated via component search
  - preselect version and milestone based on mappings below

notes:
- need to be able to close the product search field
- if any of the current groups are not valid on the new product, a very clear warning needs to be shown in the groups module

field mappings:
"try" means checking that the target value exists/is valid, and the current user can change the field to that value.

- versions
  - try direct mapping
  - try mapping between firefox versions (eg. "Firefox 32" --> "mozilla32")
  - try "unspecified"
  - set to "---"

- milestones
  - try direct mapping
  - set to default milestone

- security group
  - try direct mapping
  - set to product's default group

Attachments

(1 file)

1151745_1.patch
41.99 KB, patch
dkl
: review+
Details | Diff | Splinter Review 
add ui to minimise steps required to move bugs between products, using the component search mechanism and smart field mapping.
Thanks, I was just about to file this!
User Story: (updated)
Depends on: 1154730
Attached patch 1151745_1.patch — — Splinter Review 
- update component, version, milestone, and groups when product changed
- bring product/component searching onto show_bug
- skip confirmation page when new values are valid
Attachment #8595748 - Flags: review?(dkl)
Comment on attachment 8595748 [details] [diff] [review]
1151745_1.patch

Review of attachment 8595748 [details] [diff] [review]:
-----------------------------------------------------------------

Nits:
- When performing search and selecting same product, the component and other affected fields are highlighted. Only highlight if product is different.
- When selecting a new product and going back to old, it has the affected fields highlighted. Ideally, all highlighted fields should go back to normal.
- Note: The above changes are not worth it if it adds a lot of additional complexity.

Fix on Commits:
- Remove extensions/BugModal/template/en/default/bug_modal/groups_new_product.html.tmpl

All else works and looks good. r=dkl

::: extensions/BugModal/lib/WebService.pm
@@ +278,5 @@
> +    }
> +
> +    my $default_group_name = $product->default_security_group;
> +    if (my $default_group = first_value { $_->{group}->name eq $default_group_name } @groups) {
> +        # beacuse we always allow the default product group to be selected, it's never invalid

because
Attachment #8595748 - Flags: review?(dkl) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   0d15453..dac9873  master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
This is now live. \o/
(In reply to Mark Côté [:mcote] from comment #6)
> This is now live. \o/

Is it live?

Because I still need two steps to change the component of a bug. When I changed the bug's Product from Firefox to Core, its component list didn't update and I can't directly choose the component I want untile I hit "save changes".

By the way, why the hell we can't submit bug for "Core" directly? It affects workflow a lot I'd say.
(In reply to Mark Côté [:mcote] from comment #6)
> This is now live. \o/

Is it live?

Because I still need two steps to change the component of a bug. When I changed the bug's Product from Firefox to Core, its component list didn't update and I can't directly choose the component I want untile I hit "save changes".
(In reply to Benjamin Peng from comment #8)
> (In reply to Mark Côté [:mcote] from comment #6)
> > This is now live. \o/
> 
> Is it live?
> 
> Because I still need two steps to change the component of a bug. When I
> changed the bug's Product from Firefox to Core, its component list didn't
> update and I can't directly choose the component I want untile I hit "save
> changes".

This is only working if you have the "Use experimental user interface" pref enabled.
(In reply to Benjamin Peng from comment #7)
> By the way, why the hell we can't submit bug for "Core" directly? It affects
> workflow a lot I'd say.

you can - choose 'other products' then 'core', or use the 'find product' field to search for the component.
you could also 'switch to the advanced bug entry form' which shows 'core' on the initial product list.
Component: User Interface: Modal → User Interface
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: