1151766 - [Ringtones]The redundant text is shown in the delete dialog.

Status: VERIFIED FIXED

(Mozilla Localizations :: ar / Arabic, defect, P2)

Description

[Lancy(Leave from Mozilla)]

Attachment: Screenshot_delete dialog.png

[1.Description]:
[RTL][v2.2&v3.0][Ringtones] Delete the ringtone, the redundant text is shown in the delete dialog.
See attachment:Screenshot_delete dialog.png

[2.Testing Steps]: 
1.Set your phone language to Arabic.
2.Launch Settings ->select "Sound" ->"Manage Tones".
3.Create new ringtone from music.
4.Tap the menu icon at left side of the new ringtone and tap "Delete ringtone" in "Manege Tones" view.

[3.Expected Result]: 
4.The redundant text should not be shown in the delete dialog.

[4.Actual Result]: 
4.The redundant text is shown in the delete dialog.

[5.Reproduction build]: 
Flame 2.2 build (Affected):
Build ID               20150406002503
Gaia Revision          a6351e1197d54f8624523c2db9ba1418f2aa046f
Gaia Date              2015-04-03 22:06:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c3335a5d3063
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150406.040047
Firmware Date          Mon Apr  6 04:00:58 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build (Affected):
Build ID               20150406160205
Gaia Revision          834385f4c834238a4306bf87cc4be41615d91ff0
Gaia Date              2015-04-06 19:41:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a530b5c3b713
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150406.194015
Firmware Date          Mon Apr  6 19:40:27 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
15522

Comment 1

[Dylan Oliver [:doliver]]

I'm not sure this is worth blocking on but is there a simple fix to the way this string is constructed?

Comment 2

[Jim Porter (:squib)]

Yes: don't use \n. Use \u000A like the original string uses: https://github.com/mozilla-b2g/gaia/blob/master/apps/ringtones/locales/ringtones.en-US.properties#L14

Comment 3

[Dylan Oliver [:doliver]]

L10n issue, removing RTL dependency.

Comment 4

[Delphine Lebédel [:delphine - OOO]]

As per comment 2, I believe this is something localizers can fix in the string itself

Comment 5

[Rami Khader]

I used \u000A instead of /n

Comment 6

[Sue]

Attachment: 2015-04-16-00-29-59.png

Hi Rami,
I have verified this issue on latest build of Flame 2.2/3.0 with the same steps in comment 0. Could you help to check whether this issue is fixed or not? Thanks! :) 
See attachment:2015-04-16-00-29-59.png

Device: Flame 2.2
Build ID               20150414162502
Gaia Revision          16e948bfaaa15dbc0200135d52f16257b4eab193
Gaia Date              2015-04-14 21:08:25
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0eec28e78eb1
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150414.201515
Firmware Date          Tue Apr 14 20:15:24 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0
Build ID               20150414160204
Gaia Revision          8e28588496f82f8f069c171c65842d622b9d8d7d
Gaia Date              2015-04-14 18:43:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/de27ac2ab94f
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150414.194002
Firmware Date          Tue Apr 14 19:40:12 EDT 2015
Bootloader             L1TC000118D0

Comment 7

[Rami Khader]

Yes the issue is resolved.. Sorry for the delay

Comment 8

[Sue]

Per comment 6 and comment 7, change the status to VERIFIED,FIXED