1151832 - Remove some old workarounds for loop-server - optional parameters are now respected for PATCH /rooms/{token} and the "roomConnectionId" check no longer needs to fallback to "id"

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P3)

Description

[Mark Banner (:standard8)]

Bug 1099063 and bug 1100318 were fixed a while ago, but we've still got code in Loop rooms assuming that they weren't.

As I'm in the area, I'm going to do the little bit of extra work to drop these workarounds.

Comment 1

[Mark Banner (:standard8)]

Attachment: Remove some old workarounds for loop-server - optional parameters are now respected for PATCH /rooms/{token} and the 'roomConnectionId' check no longer needs to fallback to 'id'.

This drops the old code and removes the comments. I've tested against the production servers to make sure we still work as expected (i.e. renames work, and we're correctly prompted about new participants).

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8589098 [details] [diff] [review]
Remove some old workarounds for loop-server - optional parameters are now respected for PATCH /rooms/{token} and the 'roomConnectionId' check no longer needs to fallback to 'id'.

Review of attachment 8589098 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/84339b589128

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/84339b589128