Remove some old workarounds for loop-server - optional parameters are now respected for PATCH /rooms/{token} and the "roomConnectionId" check no longer needs to fallback to "id"

RESOLVED FIXED in Firefox 40

Status

Hello (Loop)
Client
P3
normal
Rank:
30
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla40
Points:
1
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: [tech-debt])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 1099063 and bug 1100318 were fixed a while ago, but we've still got code in Loop rooms assuming that they weren't.

As I'm in the area, I'm going to do the little bit of extra work to drop these workarounds.
(Assignee)

Comment 1

3 years ago
Created attachment 8589098 [details] [diff] [review]
Remove some old workarounds for loop-server - optional parameters are now respected for PATCH /rooms/{token} and the 'roomConnectionId' check no longer needs to fallback to 'id'.

This drops the old code and removes the comments. I've tested against the production servers to make sure we still work as expected (i.e. renames work, and we're correctly prompted about new participants).
Attachment #8589098 - Flags: review?(mdeboer)
(Assignee)

Updated

3 years ago
Blocks: 1142522
backlog: --- → tech-debt
Rank: 30
Priority: -- → P3
Comment on attachment 8589098 [details] [diff] [review]
Remove some old workarounds for loop-server - optional parameters are now respected for PATCH /rooms/{token} and the 'roomConnectionId' check no longer needs to fallback to 'id'.

Review of attachment 8589098 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8589098 - Flags: review?(mdeboer) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/84339b589128
Target Milestone: --- → mozilla40
https://hg.mozilla.org/mozilla-central/rev/84339b589128
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.