Closed Bug 1151915 Opened 9 years ago Closed 9 years ago

Make "saved-session" documentation more explicit

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

Details

Attachments

(1 file, 1 obsolete file)

Minor documentation improvement.
Attachment #8589168 - Flags: review?(vdjeric)
Comment on attachment 8589168 [details] [diff] [review]
Improve saved-session documentation

Review of attachment 8589168 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/tests/unit/test_PingAPI.js
@@ +18,5 @@
>    // and will be removed with bug 1149754.
>    yield TelemetryPing.setup();
>  
>    const PING_TYPE = "test-ping-api";
> +  let pings = new Map();

What's the motivation for this change?

@@ +25,2 @@
>    let id = yield TelemetryPing.send(PING_TYPE, {});
> +  

trailing space
Attachment #8589168 - Flags: review?(vdjeric) → review+
(In reply to Vladan Djeric (:vladan) -- please needinfo! from comment #1)
> Comment on attachment 8589168 [details] [diff] [review]
> Improve saved-session documentation
> 
> Review of attachment 8589168 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/components/telemetry/tests/unit/test_PingAPI.js
> @@ +18,5 @@
> >    // and will be removed with bug 1149754.
> >    yield TelemetryPing.setup();
> >  
> >    const PING_TYPE = "test-ping-api";
> > +  let pings = new Map();
> 
> What's the motivation for this change?

Sorry about that - the test changes are completely unrelated and from a bad patch refresh.
Removing them before landing.
Status: NEW → ASSIGNED
Attachment #8589168 - Attachment is obsolete: true
Attachment #8589577 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1f446da826ae
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: