1151955 - push_apk.py should use the future get_apk.py from bug 1151954

Status: RESOLVED WONTFIX

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Once bug #1151954 is implemented, we should use this script from mozharness push_apk.py to automatically download the apk from our ftp + upload it to Google play.

Most of the work can be tested without the Google play access.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Here is the push_apk.py script:
https://hg.mozilla.org/build/mozharness/file/tip/scripts/push_apk.py

Comment 2

[Akash Rindhe]

Attachment: Change to be made to code

I'm a newbie, and so not sure if the change made is correct or complete. Please help.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

This is not enough. First, bug 1151954 has to be implemented.

Comment 4

[Alex Johnson (:alex_johnson)]

I would like to work on this once Bug 1151954 lands.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

With pleasure!

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Thinking a bit more about this:
After get_apk.py and before calling push_apk.py, we probably want:
* a summary of the download (size, version, build 1, locale)
* a manual confirmation (Are you sure you want to upload that to Google play?)

Comment 7

[Alex Johnson (:alex_johnson)]

Would this be the only way to push an APK to the play store or would the old way of manually pushing a local file still be available?

Comment 8

[Alex Johnson (:alex_johnson)]

Sylvestre, my friend Josh would be interested in working on this.  Could I co-mentor this?

Comment 9

[Sylvestre Ledru [:Sylvestre]]

> Would this be the only way to push an APK to the play store or would the old way of manually pushing a
> local file still be available?
I think we want to keep both options.


Sure, enjoy Josh!

Comment 10

[Josh Rowlison]

Thanks!

Comment 11

[Tridev]

Attachment: push_apk.py

for Bug 1151955 
 get_apk is used from Bug 1151954

Comment 12

[Alex Johnson (:alex_johnson)]

(In reply to Tridev from comment #11)
> Created attachment 8712127 [details] [diff] [review]
> push_apk.py
> 
> for Bug 1151955 
>  get_apk is used from Bug 1151954

Please submit a valid diff patch.  Also, just adding a get_apk.py action isn't sufficient.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

by the way, don't hesitate to use mozreview - http://reviewboard.mozilla.org/

Comment 14

[Josh Rowlison]

I've been looking at this for a little while, and I'm puzzled as to how I'll acquire the variables for locale etc as required by get_apk. I could prompt for the values but I'd prefer to acquire them without that. Is there a form for the filepath that I could parse for these variables? I wasn't able to locate a document defining the form.

Comment 15

[Alex Johnson (:alex_johnson)]

Also, should we put this in mozinbound with get_apk.py?

Comment 16

[Sylvestre Ledru [:Sylvestre]]

josh, here, we only care about the default locale code (multi). Hope this helps!

Comment 17

[Sylvestre Ledru [:Sylvestre]]

(In reply to Alex Johnson (:alex_johnson) from comment #15)
> Also, should we put this in mozinbound with get_apk.py?
When reviewed, yes

Comment 18

[Josh Rowlison]

Attachment: mozPatch.patch

Think this should meet the basic goals. Let me know if I missed anything.

Comment 19

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8719618 [details] [diff] [review]
mozPatch.patch

Sorry about the lag, shame on me.
How this should be used? 
Looks like tests are missing, right?
Besides that, it looks great

Comment 20

[Josh Rowlison]

I'm a little fuzzy on which tests are missing but I'll be in person with Alex on Monday so we'll clear that up.

Comment 21

[Sylvestre Ledru [:Sylvestre]]

Josh, we need to make some progress on this, are you still interested to help? Thanks

Comment 22

[Josh Rowlison]

I am not going to be able to finish this,

My apologies, things got busy and I forgot to ever come back and note that I wasn't going to be able to finish it.

Comment 23

[Sylvestre Ledru [:Sylvestre]]

No worries, thanks for taking the time to get back to me :)

Comment 24

[Divyadeep Singh]

(In reply to Sylvestre Ledru [:sylvestre] from comment #23)
> No worries, thanks for taking the time to get back to me :)

Hello, I would like to fix this bug but am new to contributing. This is my first bug, could you show me the path please? Thanks!

Comment 25

[Ishaan]

Hello, I would like to help fix this bug. I am completely new contributing. If I am assigned this bug, could you guide me. Thanks!

Comment 26

[Darshan Chaudhary]

Hello, can I work on this bug?

Comment 27

[anrgbndhu]

I am new to open source, very interested in contribution. Need help how to get started.
I know python lang

Comment 28

[Emin Mastizada]

Hi, this bug is 2 years old, looks like repository is also changes (moved to github?).
If it is not solved yet, can you please give new location for the push_apk.py file and explain a bit what is currently missing?

It problem is already solved, it would be better to close bug.

Thanks

Comment 29

[Sylvestre Ledru [:Sylvestre]]

yeah, sorry, we moved that into our CI, I don't think it makes sense anymore.
sorry :(

Don't hesitate to drop me an email if you want to do python or C/C++ contribution.