Remove void* markers

RESOLVED FIXED in Firefox 40

Status

()

Core
JavaScript: GC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

(Blocks: 1 bug)

Trunk
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Created attachment 8589230 [details] [diff] [review]
4.10_remove_mark_internal-v0.diff

We still need to be able to mark a generic Cell* in service of the JITs, and we have enough information to do this easily. Marking void* and making the caller deal with figuring out what kind of thing to mark is a pretty terrible interface though.

This is, surprisingly, line length neutral, despite the new infrastructure for shared upcasts not being used extensively yet.
Attachment #8589230 - Flags: review?(jcoppeard)
Comment on attachment 8589230 [details] [diff] [review]
4.10_remove_mark_internal-v0.diff

Review of attachment 8589230 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good.

I had a go at doing without the functor adaptor and came up with a slightly different approach.  I'll post the patch and see what you think.
Attachment #8589230 - Flags: review?(jcoppeard) → review+
Created attachment 8589605 [details] [diff] [review]
call-typed-update

This makes CallTyped use variadic template arguments to forward everything to the functor so we don't need to put these into a TracerAdaptorFunctor first.
Attachment #8589605 - Flags: feedback?(terrence)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8589605 [details] [diff] [review]
call-typed-update

Review of attachment 8589605 [details] [diff] [review]:
-----------------------------------------------------------------

Oooo, template var args! I should have thought of that. This looks much better.
Attachment #8589605 - Flags: review+
Attachment #8589605 - Flags: feedback?(terrence)
Attachment #8589605 - Flags: feedback+
https://hg.mozilla.org/mozilla-central/rev/dd24fea25988
Assignee: nobody → terrence
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40

Comment 6

3 years ago
I landed a trivial mingw fixup (check for compiler instead of assuming that XP_WIN means MSVC):

https://hg.mozilla.org/integration/mozilla-inbound/rev/598ccd9bc144
You need to log in before you can comment on or make changes to this bug.