[l10n] Fix string consistency: "Tap to reload page", "Not now"

RESOLVED FIXED

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: flod, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Comment 1

4 years ago
Pointing links to master for "Tap to reload (the) page"
https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/BrowserToolbar.swift#L60
https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/BrowserToolbar.swift#L91

And adding a fresh one landed last night: "Not now".

"Not now"
https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/PasswordHelper.swift#L11

"Not Now"
https://github.com/mozilla/firefox-ios/blob/master/Client/Application/AppDelegate.swift#L122

Both they're marked as "button labels", I guess they should use a consistent case.
Blocks: 1092387
Component: Browser → General
Summary: Fix consistency for "Tab to reload page" string → [l10n] Fix string consistency: "Tap to reload page", "Not now"
The second "Not Now" which is not in AuroraAppDelegate.swift will go away at one point I think when we move our Aurora builds also to TestFlight. Lets not spend too much time on it.
I fixed the "Tap to reload page" string at

https://github.com/mozilla/firefox-ios/commit/0144f25f83061bdb8ce417c873fb9ee88582224b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.