Closed
Bug 1151995
Opened 10 years ago
Closed 9 years ago
[l10n] Fix string consistency: "Tap to reload page", "Not now"
Categories
(Firefox for iOS :: General, defect)
Firefox for iOS
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: flod, Unassigned)
References
Details
Currently there are two versions of this string, with and without 'the' "Tap to reload the page" https://github.com/mozilla/firefox-ios/blob/43f1cbe87b1e75fbb4602bd35e9a05412e3af324/Client/Frontend/Browser/BrowserToolbar.swift#L60 "Tap to reload page" https://github.com/mozilla/firefox-ios/blob/43f1cbe87b1e75fbb4602bd35e9a05412e3af324/Client/Frontend/Browser/BrowserToolbar.swift#L91
|
Reporter | |
Comment 1•10 years ago
|
||
Pointing links to master for "Tap to reload (the) page" https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/BrowserToolbar.swift#L60 https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/BrowserToolbar.swift#L91 And adding a fresh one landed last night: "Not now". "Not now" https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/PasswordHelper.swift#L11 "Not Now" https://github.com/mozilla/firefox-ios/blob/master/Client/Application/AppDelegate.swift#L122 Both they're marked as "button labels", I guess they should use a consistent case.
Blocks: iosl10n
Component: Browser → General
Summary: Fix consistency for "Tab to reload page" string → [l10n] Fix string consistency: "Tap to reload page", "Not now"
|
||
Comment 2•9 years ago
|
||
The second "Not Now" which is not in AuroraAppDelegate.swift will go away at one point I think when we move our Aurora builds also to TestFlight. Lets not spend too much time on it.
|
|
||
Comment 3•9 years ago
|
||
I fixed the "Tap to reload page" string at https://github.com/mozilla/firefox-ios/commit/0144f25f83061bdb8ce417c873fb9ee88582224b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•