1152112 - [steeplechase] Fx39 tests are failing because of onnegotiationneeded change

Status: RESOLVED WONTFIX

(Core :: WebRTC: Signaling, defect)

Description

[Nils Ohlmeier [:drno]]

Bug 1149838 changed the behavior of Fx 40 in regards to always emitting a onnegotiationneeded event.
As steeplechase executes tests from Aurora and Beta against a Nightly binary the tests fail on that new event from Nightly.

To fix our WebRTC QA lab tests we need to land a test change in Aurora and Beta.

Possible options:
1) Add new code to Aurora and Beta to happily accept the new event - but also do not complain if it missing
2) Remove the onnegotiationneeded unexpected failure from the tests in Aurora and Beta (note: the code in Fx40 riding the trains will eventually push that deactivated test out).

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: bug_1152112_steeplechase_negotiation_fix.patch

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1718a56e413c

Comment 2

[Maire Reavy [:mreavy]]

Nils - What's the plan for this bug? Has it been overtaken by events?

Comment 3

[Byron Campen [:bwc]]

Once 40 makes it to Beta, this problem fixes itself, right? Might make sense to just wait, since drno and I are about to go on PTO until the end of the month.

Comment 4

[Nils Ohlmeier [:drno]]

Sorry this fell of my radar. And when I was looking for it I failed to locate this.
As Beta is currently disabled on the WebRTC lab Jenkins any how we are no longer affected by this problem. And as Byron pointed out this problem is going to go away at some point in the near future.