1152124 - Text spans are not always cleared when switching focus

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Sometimes, when focus changes to the current editor, we receive NOTIFY_IME_OF_FOCUS and NOTIFY_IME_OF_BLUR notifications. Then we send a text change notification to replace previous text with the new editor's text. However, sometimes the previous text's spans are left behind and we should clear them.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Clear spans when initializing for newly-focused editor (v1)

For newly-focused text, we do a simple replacement, which will discard any previous text spans.

Comment 2

[Eugen Sawin [:esawin]]

Comment on attachment 8589365 [details] [diff] [review]
Clear spans when initializing for newly-focused editor (v1)

Review of attachment 8589365 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, I think it might help with some of the issues I've observed, too.

On a side note: we should look into refactoring the span-recovering code block sometime, the selection "clamping" could be extracted and simplified for improved readability.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/fx-team/rev/f14333eca8ce

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f14333eca8ce