1152162 - Accept-Ranges parsing

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Mark Nottingham]

MediaResource.cpp do_QueryInterface() parses the HTTP Accept-Ranges header like this:

    nsAutoCString ranges;
    hc->GetResponseHeader(NS_LITERAL_CSTRING("Accept-Ranges"),
                          ranges);
    bool acceptsRanges = ranges.EqualsLiteral("bytes");

This means that if the string "bytes" shows up in the header at all, it will match -- making it error-prone if a range using that sequence of characters is ever defined (e.g., "newbytes" as recently proposed on the HTTP WG mailing list).

The syntax isn't difficult to parse, it's a comma-separated list of tokens with optional whitespace (the same as several other headers):
  http://httpwg.github.io/specs/rfc7233.html#header.accept-ranges

(found by Rodger Combs on the IETF HTTP WG mailing list)

Comment 1

[Rodger Combs]

Correction: the existing implementation would only match if the header value is exactly "bytes", so it'd be error-prone if the server listed multiple range units including "bytes".

Comment 2

[Amy Chung [:Amy]]

Hi Kershaw,
Would you take a look at this bug?
Thanks!

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1152162 - Correct parsing Accept-Ranges header

Summary:
Simply use nsHttp::FindToken to parse Accept-Ranges header.

Thanks.

Comment 4

[Kershaw Chang [:kershaw]]

Attachment: Bug 1152162 - Correct parsing Accept-Ranges header, r=valentin

Carry r+.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5472b2d8b9a0
Correct parsing Accept-Range header, r=valentin

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5472b2d8b9a0