1152185 - media/webrtc/signaling/test/signaling_unittests.cpp fails to build with musl libc (no <sys/queue.h>)

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Felix Janda]

Attachment: Proposed patch

Build of media/webrtc/signaling/test/signaling_unittests.cpp fails on linux systems with musl libc (http://musl-libc.org) because signaling_unittests.cpp includes media/mtransport/test/stunserver.cpp, which includes media/mtransport/third_party/nrappkit/src/share/nr_api.h, which tries to include sys/queue.h, which is missing on musl.

There is a copy of sys/queue.h in media/mtransport/third_party/nrappkit/src/port/generic/include/sys/queue.h, which is used for the compilation of mtransport since media/mtransport/third_party/nrappkit/src/port/generic/include is in LOCAL_INCLUDES of media/mtransport/build/moz.build.

The attached patch puts media/mtransport/third_party/nrappkit/src/port/generic/include also into LOCAL_INCLUDES of media/webrtc/signaling/test/moz.build to fix the compilation.

Comment 1

[Eric Rescorla (:ekr)]

Comment on attachment 8589479 [details] [diff] [review]
Proposed patch

Review of attachment 8589479 [details] [diff] [review]:
-----------------------------------------------------------------

This patch looks fine, but please provide a try push demonstrating it does not cause problems and then ask for re-review.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

This needs rebasing.

Comment 3

[Felix Janda]

Attachment: Rebased patch

Comment 4

[Felix Janda]

Attachment: Expanded patch

Does now also the same to media/mtransport/test/moz.build thereby making the include consistent between mtransport/test/moz.build, mtransport/common.build and webrtc/signaling/test/common.build.

Comment 5

[Eric Rescorla (:ekr)]

Comment on attachment 8593600 [details] [diff] [review]
Expanded patch

Review of attachment 8593600 [details] [diff] [review]:
-----------------------------------------------------------------

Please provide a try push demonstrating that this doesn't break the build for other platforms.

Comment 6

[Felix Janda]

(In reply to Eric Rescorla (:ekr) from comment #5)
> Please provide a try push demonstrating that this doesn't break the build
> for other platforms.

Sorry, I don't have access to the try server. Could you do a try push for me?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96ec98c90a00

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5f9103a3f66

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a5f9103a3f66