Polish Tab Queue Prompt UI

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: mhaigh, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
once the Tab Queue Prompt initial work lands, lets revisit to polish and improve
This was filed specifically for me to re-skim the tab_queue_prompt.xml file but it can be more general than that too. :)
Flags: needinfo?(michael.l.comella)
(Reporter)

Comment 2

3 years ago
Note - this is a code refactor bug, not a visual polish issue.
Blocks: 1158260
No longer blocks: 1112185
Comments:
  * We have the LinearLayout inside the FrameLayout rather than making the outer container a LinearLayout because otherwise we can't place the toast where we want it to go, right? We should add a comment.
  * Rather than having the inner containers' widths be "tab_queue_content_width", perhaps the LinearLayout container should have some padding and the inner containers should "match_parent". Then we can remove the extra "@dimen/tab_queue_content_width". Same w/ "@dimen/tab_queue_button_width".

Martyn, if you agree with these, mentorable?
Flags: needinfo?(michael.l.comella) → needinfo?(mhaigh)
(Reporter)

Updated

3 years ago
Assignee: mhaigh → nobody
Flags: needinfo?(mhaigh)
(Reporter)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.