Closed Bug 1152244 Opened 8 years ago Closed 8 years ago

Polish Tab Queue Prompt UI

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: mhaigh, Unassigned)

References

Details

once the Tab Queue Prompt initial work lands, lets revisit to polish and improve
This was filed specifically for me to re-skim the tab_queue_prompt.xml file but it can be more general than that too. :)
Flags: needinfo?(michael.l.comella)
Note - this is a code refactor bug, not a visual polish issue.
Blocks: tab-queue-v2
No longer blocks: tab-queue
Comments:
  * We have the LinearLayout inside the FrameLayout rather than making the outer container a LinearLayout because otherwise we can't place the toast where we want it to go, right? We should add a comment.
  * Rather than having the inner containers' widths be "tab_queue_content_width", perhaps the LinearLayout container should have some padding and the inner containers should "match_parent". Then we can remove the extra "@dimen/tab_queue_content_width". Same w/ "@dimen/tab_queue_button_width".

Martyn, if you agree with these, mentorable?
Flags: needinfo?(michael.l.comella) → needinfo?(mhaigh)
Assignee: mhaigh → nobody
Flags: needinfo?(mhaigh)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.