1152340 - English localization requires en-US/firefox-ios.xliff to be imported

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

If en-US/firefox-ios.xliff is not imported, the english localization disappears from the product. It does not seem to fall back to the base (english) strings that we have in the app but instead picks a random other locale.

I am not entirely sure what is going on here. Both myself and :guerojeff observed that this actually worked ok previously. It is possible that either Xcode or iOS upgrades changed this behaviour.

The easy fix is to simply import en-US/firefox-ios.xliff as part of the l10n import process.

One catch: because en-US/firefox-ios.xliff is the file that we export from Xcode, it does not have a target-language attribute set. This should be done either manually before importing. (Xcode will complain otherwise) Or it can be done as part of one of the scripts/xliff-*.py scripts that will make up the l10n import workflow. (I would prefer the latter)

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Closing this because we are doing exactly what I suggested above: "The easy fix is to simply import en-US/firefox-ios.xliff as part of the l10n import process."

Also note that recent Xcode exports with both target-language and source-language set to 'en'.