1152361 - GonkDisplayJB.cpp - outbufAcquireFenceFd is not initialized during boot animation before calling hwc_set()

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Michael Vines [:m1] [:evilmachines]]

outbufAcquireFenceFd is not initialized in this code path:
BootAnimation.cpp::AnimationThread() ... GonkDisplayJB::QueueBuffer() .. GonkDisplayJB::Post() ... hwc_set()

The L HWC HAL will attempt to close outbufAcquireFenceFd if it's > -1, so during the boot animation Gecko is causing random fds to be close()ed.

For reference, see the closeAcquireFds() implementation in hwc_utils.cpp:
* L - https://www.codeaurora.org/cgit/quic/la/platform/hardware/qcom/display/tree/libhwcomposer/hwc_utils.cpp?h=LA.BR.1.2.3#n1461
* KK - https://www.codeaurora.org/cgit/quic/la/platform/hardware/qcom/display/tree/libhwcomposer/hwc_utils.cpp?h=LNX.LA.3.5.1#n1170

Comment 1

[Michael Vines [:m1] [:evilmachines]]

Attachment: outbufAcquireFenceFd == -1

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 8589788 [details] [diff] [review]
outbufAcquireFenceFd == -1

Review of attachment 8589788 [details] [diff] [review]:
-----------------------------------------------------------------

Good find.

Comment 3

[Michael Vines [:m1] [:evilmachines]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c06ad2247fd2

Comment 4

[Michael Vines [:m1] [:evilmachines]]

https://hg.mozilla.org/integration/b2g-inbound/rev/228fc7b34156

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/228fc7b34156

Comment 6

[Michael Vines [:m1] [:evilmachines]]

Comment on attachment 8589788 [details] [diff] [review]
outbufAcquireFenceFd == -1

Bug caused by (feature/regressing bug #): N/A
User impact if declined: Device could crash randomly during boot.
Testing completed: Test setup that detected the invalid close() now passes, plus couple days of normal FC testing has occurred as this patch has been in our tree for some time now.
Risk to taking this patch (and alternatives if risky): Close to zero.
String or UUID changes made by this patch: Zip.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0e98c1430eae