crash in mozilla::ipc::MessageChannel::Call(IPC::Message*, IPC::Message*)

RESOLVED FIXED in Firefox 39

Status

()

Core
Plug-ins
--
critical
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aklotz, Assigned: aklotz)

Tracking

({crash})

Trunk
mozilla40
crash
Points:
---

Firefox Tracking Flags

(firefox38 disabled, firefox39 fixed, firefox40 fixed)

Details

(crash signature)

Attachments

(1 attachment, 1 obsolete attachment)

This bug was filed from the Socorro interface and is 
report bp-56a8ec4c-75a3-4a6f-8747-7508b2150405.
=============================================================

I think what we're seeing here is an NP_Shutdown call coming in while async NP_Initialize is still running.
Created attachment 8589769 [details] [diff] [review]
Make NP_Shutdown async init aware

Just a blatant omission on my part: NP_Shutdown would go ahead and kill everything while NP_Initialize was still executing asynchronously. This code detects that condition, sets a flag, and then we'll check for that when processing the NP_Initialize result.
Attachment #8589769 - Flags: review?(jmathies)
status-firefox38: --- → disabled
status-firefox39: --- → affected

Comment 2

2 years ago
Comment on attachment 8589769 [details] [diff] [review]
Make NP_Shutdown async init aware

Review of attachment 8589769 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginModuleParent.cpp
@@ +2250,5 @@
>  void
>  PluginModuleParent::InitAsyncSurrogates()
>  {
> +    if (MaybeRunDeferredShutdown()) {
> +        mSurrogateInstances.Clear();

I'm not sure why you cleared this, maybe add a comment?
Attachment #8589769 - Flags: review?(jmathies) → review+
Created attachment 8589787 [details] [diff] [review]
Make NP_Shutdown async init aware (r2)

Added comment. Carrying forward r+.
Attachment #8589769 - Attachment is obsolete: true
Attachment #8589787 - Flags: review+
Thanks for the prompt review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/c288fb7b831b
https://hg.mozilla.org/mozilla-central/rev/c288fb7b831b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment on attachment 8589787 [details] [diff] [review]
Make NP_Shutdown async init aware (r2)

Approval Request Comment
[Feature/regressing bug #]: async plugin init
[User impact if declined]: crashes if plugin is shutdown too quickly after starting up
[Describe test coverage new/current, TreeHerder]: Locally, try, m-c
[Risks and why]: Low, well understood problem with a straightforward patch
[String/UUID change made/needed]: None
Attachment #8589787 - Flags: approval-mozilla-aurora?
Comment on attachment 8589787 [details] [diff] [review]
Make NP_Shutdown async init aware (r2)

Approving for aurora - we definitely want to improve the async shutdown issues.
Attachment #8589787 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/8d2d128ce671
status-firefox39: affected → fixed
You need to log in before you can comment on or make changes to this bug.