1152395 - crash in mozilla::ipc::MessageChannel::Call(IPC::Message*, IPC::Message*)

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This bug was filed from the Socorro interface and is 
report bp-56a8ec4c-75a3-4a6f-8747-7508b2150405.
=============================================================

I think what we're seeing here is an NP_Shutdown call coming in while async NP_Initialize is still running.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Make NP_Shutdown async init aware

Just a blatant omission on my part: NP_Shutdown would go ahead and kill everything while NP_Initialize was still executing asynchronously. This code detects that condition, sets a flag, and then we'll check for that when processing the NP_Initialize result.

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8589769 [details] [diff] [review]
Make NP_Shutdown async init aware

Review of attachment 8589769 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginModuleParent.cpp
@@ +2250,5 @@
>  void
>  PluginModuleParent::InitAsyncSurrogates()
>  {
> +    if (MaybeRunDeferredShutdown()) {
> +        mSurrogateInstances.Clear();

I'm not sure why you cleared this, maybe add a comment?

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Make NP_Shutdown async init aware (r2)

Added comment. Carrying forward r+.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Thanks for the prompt review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/c288fb7b831b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c288fb7b831b

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8589787 [details] [diff] [review]
Make NP_Shutdown async init aware (r2)

Approval Request Comment
[Feature/regressing bug #]: async plugin init
[User impact if declined]: crashes if plugin is shutdown too quickly after starting up
[Describe test coverage new/current, TreeHerder]: Locally, try, m-c
[Risks and why]: Low, well understood problem with a straightforward patch
[String/UUID change made/needed]: None

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8589787 [details] [diff] [review]
Make NP_Shutdown async init aware (r2)

Approving for aurora - we definitely want to improve the async shutdown issues.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8d2d128ce671