1152538 - Enable WebRTC identity by default

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Martin Thomson [:mt:]]

media.peerconnection.identity.enabled to true

Comment 1

[Martin Thomson [:mt:]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4b56823b13c

Comment 2

[Martin Thomson [:mt:]]

Attachment: MozReview Request: bz://1152538/mt

/r/7089 - Bug 1152538 - Enable WebRTC identity, r=jesup

Pull down this commit:

hg pull -r 6d4ab00190441297931e58c1eeb976cb39321149 https://reviewboard-hg.mozilla.org/gecko/

Comment 3

[Martin Thomson [:mt:]]

Whoops, the pref change exposed a need to fix test_interfaces.  I'll get onto that.

Comment 4

[Martin Thomson [:mt:]]

Comment on attachment 8593054 [details]
MozReview Request: bz://1152538/mt

/r/7089 - Bug 1152538 - Add RTCIdentityAssertion to test_interfaces.html, r=?
/r/7099 - Bug 1152538 - Enable WebRTC identity, r=jesup

Pull down these commits:

hg pull -r 56610215612d42c2b5784c5819087b6ab73f1ce5 https://reviewboard-hg.mozilla.org/gecko/

Comment 5

[Martin Thomson [:mt:]]

nb, the original code here was reviewed by jst a long time back.

Comment 6

[Martin Thomson [:mt:]]

Tested locally, but https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c1de7c2ecb3 should confirm that.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Per spec RTCIdentityAssertion should be dictionary, not interface.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

(dictionaries don't pollute global scope, like interfaces by default do)

Comment 9

[Martin Thomson [:mt:]]

Ugh, someone changed the spec while I wasn't watching.  I'll fix it.  Thanks for noticing.

Comment 10

[Martin Thomson [:mt:]]

Comment on attachment 8593054 [details]
MozReview Request: bz://1152538/mt

/r/7089 - Bug 1152538 - RTCIdentityAssertion is a dictionary, r=smaug
/r/7129 - Bug1152538 - Removing RTCIdentityAssertion interface code, r=jib
/r/7099 - Bug 1152538 - Enable WebRTC identity, r=jesup

Pull down these commits:

hg pull -r 38881ba24c13643fca39046143925607a1f3a88b https://reviewboard-hg.mozilla.org/gecko/

Comment 11

[Martin Thomson [:mt:]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=63d67cd1368c

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8593054 [details]
MozReview Request: bz://1152538/mt

https://reviewboard.mozilla.org/r/7087/#review5931

To be honest, I'm not the best reviewer for this code, but I see no problems that I understand.  I'm fine with enabling it.

Comment 13

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

https://reviewboard.mozilla.org/r/7129/#review5935

Ship It!

Comment 14

[Martin Thomson [:mt:]]

Comment on attachment 8593054 [details]
MozReview Request: bz://1152538/mt

r=jib

Thanks reviewboard for failing to deal with flags properly.

Comment 15

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Looks like it put me in the commit log automatically though, nice.

Comment 16

[Martin Thomson [:mt:]]

That was just me, preempting the eventual review grant.

Comment 17

[Martin Thomson [:mt:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9d7dda432e8
https://hg.mozilla.org/integration/mozilla-inbound/rev/b11576671375
https://hg.mozilla.org/integration/mozilla-inbound/rev/84ac619e5c3d

Comment 18

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f9d7dda432e8
https://hg.mozilla.org/mozilla-central/rev/b11576671375
https://hg.mozilla.org/mozilla-central/rev/84ac619e5c3d

Comment 20

[Martin Thomson [:mt:]]

Attachment: MozReview Request: Bug1152538 - Removing RTCIdentityAssertion interface code, r=jib

Comment 21

[Martin Thomson [:mt:]]

Attachment: MozReview Request: Bug 1152538 - Enable WebRTC identity, r=jesup

Comment 22

[Martin Thomson [:mt:]]

Attachment: MozReview Request: Bug 1152538 - RTCIdentityAssertion is a dictionary, r=smaug

Comment 23

[Eric Shepherd [:sheppy]]

Availability of this feature needs to be documented.