Closed Bug 1152538 Opened 5 years ago Closed 5 years ago

Enable WebRTC identity by default

Categories

(Core :: WebRTC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: mt, Assigned: mt)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-needed)

Attachments

(3 files, 1 obsolete file)

media.peerconnection.identity.enabled to true
Attached file MozReview Request: bz://1152538/mt (obsolete) —
/r/7089 - Bug 1152538 - Enable WebRTC identity, r=jesup

Pull down this commit:

hg pull -r 6d4ab00190441297931e58c1eeb976cb39321149 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8593054 - Flags: review?(rjesup)
Whoops, the pref change exposed a need to fix test_interfaces.  I'll get onto that.
Comment on attachment 8593054 [details]
MozReview Request: bz://1152538/mt

/r/7089 - Bug 1152538 - Add RTCIdentityAssertion to test_interfaces.html, r=?
/r/7099 - Bug 1152538 - Enable WebRTC identity, r=jesup

Pull down these commits:

hg pull -r 56610215612d42c2b5784c5819087b6ab73f1ce5 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8593054 - Flags: review?(bugs)
nb, the original code here was reviewed by jst a long time back.
Tested locally, but https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c1de7c2ecb3 should confirm that.
Per spec RTCIdentityAssertion should be dictionary, not interface.
Attachment #8593054 - Flags: review?(bugs) → review-
(dictionaries don't pollute global scope, like interfaces by default do)
Ugh, someone changed the spec while I wasn't watching.  I'll fix it.  Thanks for noticing.
Attachment #8593054 - Flags: review?(jib)
Attachment #8593054 - Flags: review?(bugs)
Attachment #8593054 - Flags: review-
Comment on attachment 8593054 [details]
MozReview Request: bz://1152538/mt

/r/7089 - Bug 1152538 - RTCIdentityAssertion is a dictionary, r=smaug
/r/7129 - Bug1152538 - Removing RTCIdentityAssertion interface code, r=jib
/r/7099 - Bug 1152538 - Enable WebRTC identity, r=jesup

Pull down these commits:

hg pull -r 38881ba24c13643fca39046143925607a1f3a88b https://reviewboard-hg.mozilla.org/gecko/
Attachment #8593054 - Flags: review?(bugs) → review+
Attachment #8593054 - Flags: review?(rjesup) → review+
Comment on attachment 8593054 [details]
MozReview Request: bz://1152538/mt

https://reviewboard.mozilla.org/r/7087/#review5931

To be honest, I'm not the best reviewer for this code, but I see no problems that I understand.  I'm fine with enabling it.
Comment on attachment 8593054 [details]
MozReview Request: bz://1152538/mt

r=jib

Thanks reviewboard for failing to deal with flags properly.
Attachment #8593054 - Flags: review?(jib) → review+
Looks like it put me in the commit log automatically though, nice.
That was just me, preempting the eventual review grant.
https://hg.mozilla.org/mozilla-central/rev/f9d7dda432e8
https://hg.mozilla.org/mozilla-central/rev/b11576671375
https://hg.mozilla.org/mozilla-central/rev/84ac619e5c3d
Assignee: nobody → martin.thomson
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Attachment #8593054 - Attachment is obsolete: true
Attachment #8619996 - Flags: review+
Attachment #8619997 - Flags: review+
Attachment #8619998 - Flags: review+
Availability of this feature needs to be documented.
Keywords: dev-doc-needed
Blocks: 1050930
You need to log in before you can comment on or make changes to this bug.