No such strategy errors in elements.js should be "invalid selector" errors

RESOLVED FIXED in Firefox 40

Status

Testing
Marionette
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

({ateam-marionette-server})

unspecified
mozilla40
ateam-marionette-server
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
The error types should change to "invalid selector" types to be in compliance with the WebDriver protocol.

Affects elements.js:599 and elements.js:666.
(Assignee)

Updated

3 years ago
Keywords: ateam-marionette-server
(Assignee)

Updated

3 years ago
Blocks: 1100545
(Assignee)

Updated

3 years ago
No longer blocks: 1100545
(Assignee)

Updated

3 years ago
Blocks: 1100545
(Assignee)

Updated

3 years ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8594738 [details]
MozReview Request: bz://1152682/ato

/r/7295 - Bug 1152682: Correct invalid selector errors in elements.js

Pull down this commit:

hg pull -r 967032a652b3d244428d338c80b11610e8aa0e0c https://reviewboard-hg.mozilla.org/gecko/
Attachment #8594738 - Flags: review?(dburns)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8594738 [details]
MozReview Request: bz://1152682/ato

/r/7295 - Bug 1152682: Correct invalid selector errors in elements.js

Pull down this commit:

hg pull -r 967032a652b3d244428d338c80b11610e8aa0e0c https://reviewboard-hg.mozilla.org/gecko/
Attachment #8594738 - Flags: review?(jgriffin)
Attachment #8594738 - Flags: review?(jgriffin) → review+
(Assignee)

Updated

3 years ago
Attachment #8594738 - Flags: review?(dburns)
https://hg.mozilla.org/mozilla-central/rev/9cfeed1582a3
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
(Assignee)

Comment 8

3 years ago
Comment on attachment 8594738 [details]
MozReview Request: bz://1152682/ato
Attachment #8594738 - Attachment is obsolete: true
Attachment #8619999 - Flags: review+
(Assignee)

Comment 9

3 years ago
Created attachment 8619999 [details]
MozReview Request: Bug 1152682: Correct invalid selector errors in elements.js
You need to log in before you can comment on or make changes to this bug.