1152697 - When saving a page to the reading list, post a VoiceOver announcement when the action finished successfully

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Marco Zehe (:MarcoZ)]

When VoiceOver is running, double-tapping and holding the Reader Mode button is the gesture to simulate a tap and hold gesture to save the current page to the reading list. When that's done, there is probably some visual indication that this was successful. There also needs to be a VoiceOver announcement posted with a localized message that tells the user that this action was successful. Right now, after double-tapping and holding, and the ascending tone was heard, nothing else happens, so one never knows whether the action was successfully completed or not.

Comment 1

[Boris Dušek]

Hello Marco,

I just tried it and there is no visual indication whatsoever that the item was added to the reading list. I filed a related https://bugzilla.mozilla.org/show_bug.cgi?id=1158503: "Adding item to Reading List by long-pressing Reader mode button issues no feedback", it also mentions accessibility aspects.

Comment 2

[Boris Dušek]

Attachment: Pull Request

At least in some cases, VoiceOver UI is ahead of the visual UI and not the other way around :-).

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8609867 [details] [review]
Pull Request

Looks pretty good overall. Left some comments in the PR.

Comment 4

[Boris Dušek]

Comment on attachment 8609867 [details] [review]
Pull Request

I addressed all review comments - please take a look at the latest comment on GitHub and hopefully merge. Thanks.

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8609867 [details] [review]
Pull Request

Taking these reviews since st3fan is buried.

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8609867 [details] [review]
Pull Request

VoiceOver feedback commit looks good.

Comment 7

[Boris Dušek]

(In reply to Brian Nicholson (:bnicholson) from comment #6)
> VoiceOver feedback commit looks good.

:bnicholson I addressed all the comments you had for other bug handled in the PR. A merge? :-)

Comment 8

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/97b0f26a43c81a9dde33a4648aa6c70ffa17fe9b