1152793 - [xh] use brandShorterName instead of brandShortName, as in en-US

Status: RESOLVED FIXED

(Mozilla Localizations :: xh / Xhosa, defect)

Description

[Axel Hecht [:Pike]]

We introduced brandShorterName to fix some UI problems on Developer Edition.

Looking at the localization in Xhosa, that didn't make it into your localization.

Please change the variable references, you should get warnings both on the l10n dashboard and on pootle.

Comment 1

[Jeff Beatty [:gueroJeff]]

We've done a review of Fx42 and Fennec42 and this bug still exists. Please correct and request a new sign-off review.

Comment 2

[Devon]

Hi Jeff,

I believe our Xhosa translator has now changed all instances of brandShortName to brandShorterName.

Please let us know if there's anything else we can assist with.

Thank you.

Comment 3

[Axel Hecht [:Pike]]

I like that the prefixing got fixed widely.

Replacing all instances of brandShortName with brandShorterName was not the intent here, though. I should have phrased that more clearly.

brandShorterName should be continued to be used in the strings in this query:
http://mozilla.locamotion.org/xh/firefox/translate/user1/#search=brandShorterName&sfields=source

brandShortName should be used here: http://mozilla.locamotion.org/xh/firefox/translate/user1/#search=brandShortName&sfields=source. These now widely use brandShorterName, which pootle rightly errors on.

Sorry for the confusion.

Comment 4

[Francesco Lodolo [:flod]]

Note that this is currently breaking the multilocale build on mozilla-aurora (not just the xh build), so we need to fix this as soon as possible.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #4)
> Note that this is currently breaking the multilocale build on mozilla-aurora
> (not just the xh build), so we need to fix this as soon as possible.

Given that this is blocking testing for all locales, we need to temporarily remove Xhosa from the multi-locale build.

We can revert this decision when all errors are fixed, as Axel already explained in comment 3.

Comment 6

[ian.henderson]

Hello Flod,
Soory about the havoc caused. Is it possible to roll back the changes made yesterday? Or is that a major exercise?

Comment 7

[Jeff Beatty [:gueroJeff]]

We could revert them, but Pootle will automatically commit them back. Dwayne would need to turn off automated commits for xh until the bug is resolved. Checking with him to see if this is an option. To be safe and to be able to respin the build soon, I think we should still proceed with removing it for the next couple of days while this is being fixed. We can easily add it back once we're in the clear.

Comment 8

[ian.henderson]

It is a public holiday in South Africa tomorrow. Getting this fixed will be Friday at the earliest.

Comment 9

[Jeff Beatty [:gueroJeff]]

I spoke with Dwayne and it would be costly for him to turn off automated pushes to the repository. He may not even be able to accomplish it until Friday, at which point it woulnd't be valuable anymore. 

The option with the least cost and widest impact is to pull xh for the next few days. This is only applicable to Aurora 43 (a likely very small userbase), so 42 and 41 are just fine and anyone using xh from the Play store is still able to do so without problem.

Comment 10

[Dwayne Bailey]

Ian, this would be a better link to fix these on Aurora 43 (166 occurances) http://mozilla.locamotion.org/xh/firefox/translate/#filter=checks&checks=variables - that should pick up any of the new snarfus.

Android is also impacted so this link is to those (60 occurances) http://mozilla.locamotion.org/xh/mobile/translate/#filter=checks&checks=variables

Comment 11

[ian.henderson]

Both products have been fixed.
Sorry about the screw up here.

Comment 12

[ian.henderson]

Did the reversal of changes fix the build?

Comment 13

[Dwayne Bailey]

Did a quick review and it seems both Aurora 43 and Mobile 43 are now correct with no browserShort*Name issues.  NI Jeff to renable xh mobile building.

Comment 14

[Axel Hecht [:Pike]]

I'll resolve this FIXED, as I think this particular problem is fixed.

For mobile, Jeff and I will have a conversation when he's back.