Tab tray thumbnails don't fill tiles

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dhenein, Assigned: sleroux)

Tracking

unspecified
x86
iOS 8

Firefox Tracking Flags

(fennec+)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
After the collection view port, tab tiles are sized dynamically. When in landscape mode, the thumbnail we get from the transitioning webview is very short, and does not fill the tile completely.

Would be nice to find a way to capture taller screenshots.
tracking-fennec: ? → +
(Assignee)

Updated

3 years ago
Assignee: nobody → sleroux
(Assignee)

Comment 1

3 years ago
Created attachment 8603482 [details] [diff] [review]
PR
Attachment #8603482 - Flags: review?(bnicholson)
Created attachment 8603486 [details] [review]
PR
Attachment #8603482 - Attachment is obsolete: true
Attachment #8603482 - Flags: review?(bnicholson)
Attachment #8603486 - Flags: review?(bnicholson)
Comment on attachment 8603486 [details] [review]
PR

Looks like this will need a bit more investigation.
Attachment #8603486 - Flags: review?(bnicholson)
(Assignee)

Comment 4

3 years ago
I spoke with @darrinhenein and I think we can make the thumbnail image scale enough to fill the cell when the screenshot will be too narrow to fill the cell's height. The only downside of this is the right edge of the snapshot on iPhone landscape won't align with the edge of the web page like it does on portrait
(Assignee)

Comment 5

3 years ago
Created attachment 8614690 [details]
iOS Simulator Screen Shot Jun 3, 2015, 10.41.28 AM.png
(Assignee)

Comment 6

3 years ago
Created attachment 8614691 [details]
iOS Simulator Screen Shot Jun 3, 2015, 10.43.29 AM.png

Doesn't look like it's an issue anymore. I can't seem to pinpoint the change but the UIImageView frame is now scaling down correctly. I've attached a before and after screenshot
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.