Closed
Bug 1152858
Opened 9 years ago
Closed 9 years ago
Tab tray thumbnails don't fill tiles
Categories
(Firefox for iOS :: Theme & Visual Design, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | + | --- |
People
(Reporter: dhenein, Assigned: sleroux)
Details
Attachments
(3 files, 1 obsolete file)
iOS Simulator Screen Shot Jun 3, 2015, 10.41.28 AM.png
After the collection view port, tab tiles are sized dynamically. When in landscape mode, the thumbnail we get from the transitioning webview is very short, and does not fill the tile completely. Would be nice to find a way to capture taller screenshots.
|
||
Updated•9 years ago
|
tracking-fennec: ? → +
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → sleroux
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8603482 -
Flags: review?(bnicholson)
|
|
||
Comment 2•9 years ago
|
||
Attachment #8603482 -
Attachment is obsolete: true
Attachment #8603482 -
Flags: review?(bnicholson)
Attachment #8603486 -
Flags: review?(bnicholson)
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8603486 [details] [review] PR Looks like this will need a bit more investigation.
Attachment #8603486 -
Flags: review?(bnicholson)
|
|
Assignee | |
Comment 4•9 years ago
|
||
I spoke with @darrinhenein and I think we can make the thumbnail image scale enough to fill the cell when the screenshot will be too narrow to fill the cell's height. The only downside of this is the right edge of the snapshot on iPhone landscape won't align with the edge of the web page like it does on portrait
|
|
Assignee | |
Comment 5•9 years ago
|
||
|
|
Assignee | |
Comment 6•9 years ago
|
||
Doesn't look like it's an issue anymore. I can't seem to pinpoint the change but the UIImageView frame is now scaling down correctly. I've attached a before and after screenshot
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•