1152865 - Incorrect syntax for gaia-ui-test in trychooser

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Andreas Tolfsen ❲:ato❳]

trychooser lists "gaia-ui-test" as a permitted job type to include in your try syntax, but if you compare it to the list of available jobs in https://dxr.mozilla.org/mozilla-central/source/testing/taskcluster/tasks/job_flags.yml#154-180, it appears to have been split into:

  - gaia-ui-test-functional
  - gaia-ui-test-oop
  - gaia-ui-test-unit

I'm not sure when this happened, but specifying "gaia-ui-test" in your try syntax _will not_ currently trigger the tests.

There also appears to be a number of *-oop jobs that are not listed on trychooser.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Like wise, there is no gaia-integration but gaia-js-integration.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This is the file to patch

https://hg.mozilla.org/build/tools/file/98498a0c5840/trychooser/index.html

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch

Drive-by patch for the differences spotted in this bug.

The lazy way to fix this once for all would be to CORS the yml and render the TryChooser page on the fly, but I don't know how exactly they are being mapped.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

$ curl -I https://hg.mozilla.org/mozilla-central/raw-file/tip/testing/taskcluster/tasks/job_flags.yml
HTTP/1.1 200 Script output follows
Server: Apache
Vary: Accept-Encoding
Content-Type: text/plain; charset="UTF-8"
Date: Sat, 16 May 2015 03:29:17 GMT
Access-Control-Allow-Origin: *
ETag: 1431736178.34
Content-Disposition: inline; filename="job_flags.yml"
Connection: Keep-Alive
Content-Length: 8014

Comment 5

[(PTO June 19-July 7) Ryan VanderMeulen]

Comment on attachment 8606591 [details] [diff] [review]
Patch

Review of attachment 8606591 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine, but it would be nice if we still had an option to run all Gaia UI tests easily with the sub-suites listed below. We do similar nesting on other platforms for various tests.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #5)
> This looks fine, but it would be nice if we still had an option to run all
> Gaia UI tests easily with the sub-suites listed below. We do similar nesting
> on other platforms for various tests.

I don't really know how to do that in TryChooser page along. It looks like these meta-suite checkboxes come with their own syntax. If I format the page that way, the syntax does not expand automatically.

Let's check this in first?

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Ryan, is checkin-needed not the correct flag to set here?

Comment 8

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/build/tools/rev/984de21b6612

You'll need to file a WebOps::Product Delivery bug to get it deployed.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

RyanVM, fyi RelEng can deploy this without WebOps help. Just ping buildduty to follow
 https://wiki.mozilla.org/ReleaseEngineering/TryChooser#How_to_Deploy_TryChooser_changes

Comment 10

[(PTO June 19-July 7) Ryan VanderMeulen]

Good to know, thanks for the heads-up.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Deployed on http://trychooser.pub.build.mozilla.org/