1152873 - Get TabQueueDispatcher to use SafeIntent

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

Currently TabQueueDispatcher doesn't use a safe intent, this needs to change!

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: Get TabQueueDispatcher to use SafeIntent

this seems to be the only place in the tab queue work where we aren't using a SafeIntent when accessing Intent data.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8590383 [details] [diff] [review]
Get TabQueueDispatcher to use SafeIntent

Review of attachment 8590383 [details] [diff] [review]:
-----------------------------------------------------------------

No need for this if you're only going to immediately unwrap. SafeIntent just lets you safely access the intent, and you're not doing that here.

Look for uses like .getStringExtra; those are the places that you need it. Like here:

        // The URL is usually hiding somewhere in the extra text. Extract it.
        final String dataString = intent.getDataString();

You might need to extend SafeIntent to add getDataString. And you might prefer to use the static variants rather than creating and then unwrapping everywhere. Something like:

        final String dataString = SafeIntent.getDataString(intent);    // Might be null.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8590383 [details] [diff] [review]
Get TabQueueDispatcher to use SafeIntent

Ah, I already did! Carry on :)

Comment 4

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/ad2b638ad358

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ad2b638ad358