Remove unnecessary expiresIn parameter when creating rooms

RESOLVED FIXED in Firefox 40

Status

Hello (Loop)
Client
P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla40
Points:
2
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
When we first implemented rooms, "expiresIn" was a required parameter for room creation. That changed to optional at some stage, but we never updated the client.

I've double checked and the server timeout is the same as ours - 8 weeks. Its also better for it just to be set by the server, as then we don't have to change the clients should we ever want to adjust it.

It would help to have this cleaned up for some of the context work I'm doing.
(Assignee)

Comment 1

3 years ago
Created attachment 8590447 [details] [diff] [review]
Remove expiresIn from the create room message for Hello as the server has its own default.

Simple patch to remove the parameter. I've tested against the production server and checked the value of expiresAt returned in the response of the POST request.
Attachment #8590447 - Flags: review?(mdeboer)
(Assignee)

Updated

3 years ago
Iteration: --- → 40.1 - 13 Apr
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
Comment on attachment 8590447 [details] [diff] [review]
Remove expiresIn from the create room message for Hello as the server has its own default.

Review of attachment 8590447 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8590447 - Flags: review?(mdeboer) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/6f32209af61a
Target Milestone: --- → mozilla40
https://hg.mozilla.org/mozilla-central/rev/6f32209af61a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.