1153050 - Add ICameraControl check to MediaEngineGonkVideoSource::Start()

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Sotaro Ikeda [:sotaro]]

This bug is created based on Bug 1150271 comment 11.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Add ICameraControl check to MediaEngineGonkVideoSource::Start()

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8590580 [details] [diff] [review]
Add ICameraControl check to MediaEngineGonkVideoSource::Start()

Review of attachment 8590580 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/webrtc/MediaEngineGonkVideoSource.cpp
@@ +223,5 @@
>  
>    if (mState == kStarted) {
>      return NS_OK;
> +  } else if (!mCameraControl) {
> +    LOG(("mCameraControl is nullptr"));

I take it this can simply happen, so we shouldn't be MOZ_ASSERT() (or NS_ASSERTION()) here?

Comment 3

[Sotaro Ikeda [:sotaro]]

Yup, I am going to add MOZ_ASSERT() here.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: Add ICameraControl check to MediaEngineGonkVideoSource::Start()

Apply the comment. Carry "r=jesup".

Comment 5

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/77ab3d086a13

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/77ab3d086a13

Comment 7

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8590860 [details] [diff] [review]
Add ICameraControl check to MediaEngineGonkVideoSource::Start()

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: An application might crash.
Testing completed: locally tested.
Risk to taking this patch (and alternatives if risky): low. 
String or UUID changes made by this patch: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4ebb9c555914