1153097 - ADTS conversion getting it wrong for sample rate > 64kHz

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

A tad silly mistake:
Adts::GetFrequencyIndex(uint16_t aSamplesPerSecond)

then go on to compare aSamplesPerSecond against 96000 and 88200.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Use 32 bits int to compare frequencies

Stage 6. how did that ever work? :)

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8590649 [details] [diff] [review]
Use 32 bits int to compare frequencies

Review of attachment 8590649 [details] [diff] [review]:
-----------------------------------------------------------------

Oops indeed!

::: media/libstagefright/binding/Adts.cpp
@@ +22,3 @@
>  
>    int8_t i = 0;
> +  while (freq_lookup[i] && aSamplesPerSecond < freq_lookup[i]) {

I think the null check is redundant with the < check since aSamplesPerSecond is unsigned? Not complaining though.

Comment 3

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/662d417e5e67

Comment 4

[Guilherme Lima]

This patch landed on central but didn't got marked as such - https://hg.mozilla.org/mozilla-central/rev/662d417e5e67