1153187 - Build process is broken while reticulating splines "Variable SHARED_LIBRARY_LIBS" involved.

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Frederic Bezies]

I have a bug when I try to build thunderbird from mercurial repository.

Everything goes well, until it starts "reticulating splines".

Crash log :

js/src> creating ./config.status

Reticulating splines...
Traceback (most recent call last):
  File "./config.status", line 1009, in <module>
    config_status(**args)
  File "/home/fred/logs/mail/src/mozilla/python/mozbuild/mozbuild/config_status.py", line 149, in config_status
    summary = the_backend.consume(definitions)
  File "/home/fred/logs/mail/src/mozilla/python/mozbuild/mozbuild/backend/base.py", line 200, in consume
    self.consume_finished()
  File "/home/fred/logs/mail/src/mozilla/python/mozbuild/mozbuild/backend/recursivemake.py", line 755, in consume_finished
    self._check_blacklisted_variables(makefile_in, content)
  File "/home/fred/logs/mail/src/mozilla/python/mozbuild/mozbuild/backend/recursivemake.py", line 698, in _check_blacklisted_variables
    'only be defined in moz.build files.' % (x, makefile_in))
Exception: Variable SHARED_LIBRARY_LIBS is defined in /home/fred/logs/mail/src/mailnews/import/build/Makefile.in. It should only be defined in moz.build files.
*** Fix above errors and then restart with\
               "make -f client.mk build"
/home/fred/logs/mail/src/client.mk:361: recipe for target 'configure' failed
make[1]: *** [configure] Error 1
make[1]: Leaving directory '/home/fred/logs/mail/src'
client.mk:375: recipe for target '/home/fred/logs/mail/objdir-tb/Makefile' failed
make: *** [/home/fred/logs/mail/objdir-tb/Makefile] Error 2

Build process was working yesterday.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This needs a port of the changes in bug 852814.

Comment 2

[Brian O'Keefe [:bokeefe]]

I think the only thing needed is part 3 of bug 1138063. I'm able to build locally with that applied, at least.

Comment 3

[Philip Chee]

(In reply to Brian O'Keefe [:bokeefe] from comment #2)
> I think the only thing needed is part 3 of bug 1138063. I'm able to build
> locally with that applied, at least.

"This file contains only whitespace changes."
Not very useful

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Maybe you were looking at the wrong part 3? I applied this one and it works:

https://hg.mozilla.org/try-comm-central/rev/a7e4571632d2

See this try build:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=adff286f79d5

The mac try failure is due to the other patches I am testing and not related to this bug.

Comment 5

[Philip Chee]

(In reply to Philipp Kewisch [:Fallen] from comment #4)
> Maybe you were looking at the wrong part 3? I applied this one and it works:
> 
> https://hg.mozilla.org/try-comm-central/rev/a7e4571632d2
I was looking at:
https://reviewboard.mozilla.org/r/4493/diff/1-2/
Where did you find:
https://hg.mozilla.org/try-comm-central/rev/a7e4571632d2

Comment 7

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=15642
repository: comm-central
start_time: 2015-04-11T09:27:57
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-linux64-spot-1001
buildname: TB Linux comm-central build
revision: 8e84e1b51ec8

Exception: Variable SHARED_LIBRARY_LIBS is defined in /builds/slave/tb-c-cen-lx-000000000000000000/build/mailnews/import/build/Makefile.in. It should only be defined in moz.build files.
make[2]: *** [configure] Error 1
make[1]: *** [/builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb/Makefile] Error 2
make: *** [build] Error 2

Comment 8

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=15645
repository: comm-central
start_time: 2015-04-11T09:28:17
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-linux64-spot-045
buildname: TB Linux comm-central leak test build
revision: 8e84e1b51ec8

Exception: Variable SHARED_LIBRARY_LIBS is defined in /builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/import/build/Makefile.in. It should only be defined in moz.build files.
make[2]: *** [configure] Error 1
make[1]: *** [/builds/slave/tb-c-cen-lx-d-0000000000000000/build/objdir-tb/Makefile] Error 2
make: *** [build] Error 2

Comment 9

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=15637
repository: comm-central
start_time: 2015-04-11T09:27:47
who: mkmelin+mozilla[at]iki[dot]fi
machine: b-2008-ix-0079
buildname: TB WINNT 5.2 comm-central leak test build
revision: 8e84e1b51ec8

mozmake.exe[2]: *** [configure] Error 1
mozmake.exe[1]: *** [c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/objdir-tb/Makefile] Error 2
mozmake.exe: *** [build] Error 2
command timed out: 10800 seconds without output, attempting to kill
remoteFailed: [Failure instance: Traceback from remote host -- Traceback (most recent call last):

Comment 10

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=15638
repository: comm-central
start_time: 2015-04-11T09:27:58
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-linux64-spot-009
buildname: TB Linux x86-64 comm-central build
revision: 8e84e1b51ec8

Exception: Variable SHARED_LIBRARY_LIBS is defined in /builds/slave/tb-c-cen-l64-00000000000000000/build/mailnews/import/build/Makefile.in. It should only be defined in moz.build files.
make[2]: *** [configure] Error 1
make[1]: *** [/builds/slave/tb-c-cen-l64-00000000000000000/build/objdir-tb/Makefile] Error 2
make: *** [build] Error 2

Comment 11

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=15643
repository: comm-central
start_time: 2015-04-11T09:27:47
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-lion-r5-081
buildname: TB OS X 10.7 64-bit comm-central leak test build
revision: 8e84e1b51ec8

Exception: Variable SHARED_LIBRARY_LIBS is defined in /builds/slave/tb-c-cen-m64-d-000000000000000/build/mailnews/import/build/Makefile.in. It should only be defined in moz.build files.
make[2]: *** [configure] Error 1
make[1]: *** [/builds/slave/tb-c-cen-m64-d-000000000000000/build/objdir-tb/Makefile] Error 2
make: *** [build] Error 2

Comment 12

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=15644
repository: comm-central
start_time: 2015-04-11T09:27:48
who: mkmelin+mozilla[at]iki[dot]fi
machine: b-2008-ix-0142
buildname: TB WINNT 5.2 comm-central build
revision: 8e84e1b51ec8

mozmake.exe[2]: *** No rule to make target 'root.mk'.  Stop.
mozmake.exe[1]: *** [build] Error 2
mozmake.exe: *** [build] Error 2

Comment 13

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=15640
repository: comm-central
start_time: 2015-04-11T09:27:50
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-lion-r5-093
buildname: TB OS X 10.7 comm-central build
revision: 8e84e1b51ec8

Exception: Variable SHARED_LIBRARY_LIBS is defined in /builds/slave/tb-c-cen-m64-00000000000000000/build/mailnews/import/build/Makefile.in. It should only be defined in moz.build files.
make[3]: *** [configure] Error 1
make[2]: *** [/builds/slave/tb-c-cen-m64-00000000000000000/build/objdir-tb/i386/config.status] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 14

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=15685
repository: comm-central
start_time: 2015-04-12T03:02:33
who: mkmelin+mozilla[at]iki[dot]fi
machine: b-2008-ix-0069
buildname: TB WINNT 5.2 comm-central nightly
revision: 8e84e1b51ec8

Exception: Variable SHARED_LIBRARY_LIBS is defined in c:/builds/moz2_slave/tb-c-cen-w32-ntly-000000000000/build/mailnews/import/build/Makefile.in. It should only be defined in moz.build files.
mozmake.exe[2]: *** [configure] Error 1
mozmake.exe[1]: *** [c:/builds/moz2_slave/tb-c-cen-w32-ntly-000000000000/build/objdir-tb/Makefile] Error 2
mozmake.exe: *** [build] Error 2

Comment 15

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=15682
repository: comm-central
start_time: 2015-04-12T03:02:17
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-linux64-spot-096
buildname: TB Linux comm-central nightly
revision: 8e84e1b51ec8

Exception: Variable SHARED_LIBRARY_LIBS is defined in /builds/slave/tb-c-cen-lx-ntly-0000000000000/build/mailnews/import/build/Makefile.in. It should only be defined in moz.build files.
make[2]: *** [configure] Error 1
make[1]: *** [/builds/slave/tb-c-cen-lx-ntly-0000000000000/build/objdir-tb/Makefile] Error 2
make: *** [build] Error 2

Comment 16

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=15684
repository: comm-central
start_time: 2015-04-12T03:03:17
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-lion-r5-071
buildname: TB OS X 10.7 comm-central nightly
revision: 8e84e1b51ec8

Exception: Variable SHARED_LIBRARY_LIBS is defined in /builds/slave/tb-c-cen-m64-ntly-000000000000/build/mailnews/import/build/Makefile.in. It should only be defined in moz.build files.
make[3]: *** [configure] Error 1
make[2]: *** [/builds/slave/tb-c-cen-m64-ntly-000000000000/build/objdir-tb/i386/Makefile] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 17

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=15683
repository: comm-central
start_time: 2015-04-12T03:02:35
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-linux64-spot-1007
buildname: TB Linux x86-64 comm-central nightly
revision: 8e84e1b51ec8

Exception: Variable SHARED_LIBRARY_LIBS is defined in /builds/slave/tb-c-cen-l64-ntly-000000000000/build/mailnews/import/build/Makefile.in. It should only be defined in moz.build files.
make[2]: *** [configure] Error 1
make[1]: *** [/builds/slave/tb-c-cen-l64-ntly-000000000000/build/objdir-tb/Makefile] Error 2
make: *** [build] Error 2

Comment 18

[Magnus Melin [:mkmelin]]

(In reply to Philipp Kewisch [:Fallen] from comment #4)
> Maybe you were looking at the wrong part 3? I applied this one and it works:
> 
> https://hg.mozilla.org/try-comm-central/rev/a7e4571632d2

Submit a patch?

Comment 19

[Josiah Bruner [:jsbruner]]

Attachment: Fix.

Comment 20

[Magnus Melin [:mkmelin]]

Comment on attachment 8591414 [details] [diff] [review]
Fix.

Review of attachment 8591414 [details] [diff] [review]:
-----------------------------------------------------------------

If you don't mind, I'll steal this review and land it in a moment. I can confirm it builds

Comment 21

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/64c2c682adb6 -> FIXED

Comment 22

[:aceman]

So this bug is marked as the reason for the closed comm-central tree.
It seems all platforms are building now again:
https://treeherder.mozilla.org/#/jobs?repo=comm-central

Can you please open the tree? Thanks for the fix!

Comment 23

[[e-mail]]

Comment on attachment 8591414 [details] [diff] [review]
Fix.

>+        'msgbsutl_s'
Huh, I thought the original patch had a comma here.

Comment 24

[Magnus Melin [:mkmelin]]

Attachment: bug1153187_add_comma.patch

Add the missing comma

Comment 25

[Philip Chee]

Comment on attachment 8594092 [details] [diff] [review]
bug1153187_add_comma.patch

https://hg.mozilla.org/comm-central/rev/bd65e57846dd