Cannot pass extra arguments to l10n-repack.py

RESOLVED FIXED in Firefox 38

Status

Firefox Build System
General
RESOLVED FIXED
3 years ago
5 months ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

unspecified
mozilla40
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(firefox38 fixed, firefox39 fixed, firefox40 fixed)

Details

Attachments

(1 attachment)

When including l10n.mk it is not possible to pass extra arguments to l10n-repack.py. I have a small patch that fixes it.
(Assignee)

Updated

3 years ago
Blocks: 1130854
Created attachment 8590787 [details] [diff] [review]
Fix - v1
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8590787 - Flags: review?(gps)
CC'ing Mike in case he wants to take this one too :)

Updated

3 years ago
Attachment #8590787 - Flags: review?(gps) → review+
Comment on attachment 8590787 [details] [diff] [review]
Fix - v1

Approval Request Comment
[Feature/regressing bug #]: Feature
[User impact if declined]: Needed for Thunderbird 38 + Lightning
[Describe test coverage new/current, TreeHerder]: None yet, but as long as this variable is undefined it will be no different than before.
[Risks and why]: no known risks
[String/UUID change made/needed]: none
Attachment #8590787 - Flags: approval-mozilla-beta?
Attachment #8590787 - Flags: approval-mozilla-aurora?
Comment on attachment 8590787 [details] [diff] [review]
Fix - v1

Beta+ Aurora+
Attachment #8590787 - Flags: approval-mozilla-beta?
Attachment #8590787 - Flags: approval-mozilla-beta+
Attachment #8590787 - Flags: approval-mozilla-aurora?
Attachment #8590787 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/7125873a632f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.