Closed Bug 1153192 Opened 6 years ago Closed 6 years ago

Cannot pass extra arguments to l10n-repack.py

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(firefox38 fixed, firefox39 fixed, firefox40 fixed)

RESOLVED FIXED
mozilla40
Tracking Status
firefox38 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

When including l10n.mk it is not possible to pass extra arguments to l10n-repack.py. I have a small patch that fixes it.
Attached patch Fix - v1Splinter Review
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8590787 - Flags: review?(gps)
CC'ing Mike in case he wants to take this one too :)
Attachment #8590787 - Flags: review?(gps) → review+
Comment on attachment 8590787 [details] [diff] [review]
Fix - v1

Approval Request Comment
[Feature/regressing bug #]: Feature
[User impact if declined]: Needed for Thunderbird 38 + Lightning
[Describe test coverage new/current, TreeHerder]: None yet, but as long as this variable is undefined it will be no different than before.
[Risks and why]: no known risks
[String/UUID change made/needed]: none
Attachment #8590787 - Flags: approval-mozilla-beta?
Attachment #8590787 - Flags: approval-mozilla-aurora?
Comment on attachment 8590787 [details] [diff] [review]
Fix - v1

Beta+ Aurora+
Attachment #8590787 - Flags: approval-mozilla-beta?
Attachment #8590787 - Flags: approval-mozilla-beta+
Attachment #8590787 - Flags: approval-mozilla-aurora?
Attachment #8590787 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/7125873a632f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.