Closed Bug 1153192 Opened 8 years ago Closed 8 years ago

Cannot pass extra arguments to l10n-repack.py

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox38 fixed, firefox39 fixed, firefox40 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox38 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

Fix - v1
624 bytes, patch
gps
: review+
lmandel
: approval-mozilla-aurora+
lmandel
: approval-mozilla-beta+
Details | Diff | Splinter Review 
When including l10n.mk it is not possible to pass extra arguments to l10n-repack.py. I have a small patch that fixes it.
Attached patch Fix - v1 — — Splinter Review 
Assignee: nobody → philipp
Status: NEW → ASSIGNED

        Attachment #8590787 -
        Flags: review?(gps)

    
    

    
  
CC'ing Mike in case he wants to take this one too :)

        Attachment #8590787 -
        Flags: review?(gps) → review+

    
    

    
  
Comment on attachment 8590787 [details] [diff] [review]
Fix - v1

Approval Request Comment
[Feature/regressing bug #]: Feature
[User impact if declined]: Needed for Thunderbird 38 + Lightning
[Describe test coverage new/current, TreeHerder]: None yet, but as long as this variable is undefined it will be no different than before.
[Risks and why]: no known risks
[String/UUID change made/needed]: none

        Attachment #8590787 -
        Flags: approval-mozilla-beta?

        Attachment #8590787 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8590787 [details] [diff] [review]
Fix - v1

Beta+ Aurora+

        Attachment #8590787 -
        Flags: approval-mozilla-beta?

        Attachment #8590787 -
        Flags: approval-mozilla-beta+

        Attachment #8590787 -
        Flags: approval-mozilla-aurora?

        Attachment #8590787 -
        Flags: approval-mozilla-aurora+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/7125873a632f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox40:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.