Closed Bug 1153198 Opened 5 years ago Closed 5 years ago

AddonWatcher disables add-ons without my consent

Categories

(Toolkit :: Performance Monitoring, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: Yoric, Assigned: Yoric)

References

Details

Attachments

(1 file, 1 obsolete file)

I regularly see the yellow bar triggered by the AddonWatcher informing me that I need to restart to disable an add-on – although I haven't clicked on "disable". That's not good.

Brad, do you know why this happens?
Flags: needinfo?(blassey.bugs)
(In reply to David Rajchenbach-Teller [:Yoric] (use "needinfo") from comment #0)
> I regularly see the yellow bar triggered by the AddonWatcher informing me
> that I need to restart to disable an add-on – although I haven't clicked on
> "disable". That's not good.
> 
> Brad, do you know why this happens?

I've never seen that. I don't know how it could happen. You should only see the restart message if the callback for the button labeled disable is called and the addon requires restart to be disabled.

https://mxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#639

The only thing I can think of is that you're hitting the access key for that button without knowing it. Perhaps we should get rid of the access key?
Flags: needinfo?(blassey.bugs)
I just saw it happen live. I hit Ctrl-D to delete a character, this was interpreted as "Disable Addon". Yeah, let's get rid of that access key.
Attached file MozReview Request: bz://1153198/Yoric (obsolete) —
/r/7593 - Bug 1153198 - Remove accesskey for disabling add-onw;r=blassey

Pull down this commit:

hg pull -r acdb476e88280e5bc8b71f79c345dc5403b5d556 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8597202 - Flags: review?(blassey.bugs)
Comment on attachment 8597202 [details]
MozReview Request: bz://1153198/Yoric

This should be reviewed by a browser peer (like mossop) but I don't know how to redirect a reviewboard review
Attachment #8597202 - Flags: review?(blassey.bugs) → review?(dtownsend)
Comment on attachment 8597202 [details]
MozReview Request: bz://1153198/Yoric

https://reviewboard.mozilla.org/r/7591/#review6395

Ship It!
Attachment #8597202 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/mozilla-central/rev/1e6108d642bf
Assignee: nobody → dteller
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Attachment #8597202 - Attachment is obsolete: true
Attachment #8620016 - Flags: review+
Depends on: 1192901
You need to log in before you can comment on or make changes to this bug.