1153198 - AddonWatcher disables add-ons without my consent

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

I regularly see the yellow bar triggered by the AddonWatcher informing me that I need to restart to disable an add-on – although I haven't clicked on "disable". That's not good.

Brad, do you know why this happens?

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to David Rajchenbach-Teller [:Yoric] (use "needinfo") from comment #0)
> I regularly see the yellow bar triggered by the AddonWatcher informing me
> that I need to restart to disable an add-on – although I haven't clicked on
> "disable". That's not good.
> 
> Brad, do you know why this happens?

I've never seen that. I don't know how it could happen. You should only see the restart message if the callback for the button labeled disable is called and the addon requires restart to be disabled.

https://mxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#639

The only thing I can think of is that you're hitting the access key for that button without knowing it. Perhaps we should get rid of the access key?

Comment 2

[David Teller [:Yoric] - still alive but not very active]

I just saw it happen live. I hit Ctrl-D to delete a character, this was interpreted as "Disable Addon". Yeah, let's get rid of that access key.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: MozReview Request: bz://1153198/Yoric

/r/7593 - Bug 1153198 - Remove accesskey for disabling add-onw;r=blassey

Pull down this commit:

hg pull -r acdb476e88280e5bc8b71f79c345dc5403b5d556 https://reviewboard-hg.mozilla.org/gecko/

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8597202 [details]
MozReview Request: bz://1153198/Yoric

This should be reviewed by a browser peer (like mossop) but I don't know how to redirect a reviewboard review

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8597202 [details]
MozReview Request: bz://1153198/Yoric

https://reviewboard.mozilla.org/r/7591/#review6395

Ship It!

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=acdb476e8828

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1e6108d642bf

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1e6108d642bf

Comment 10

[David Teller [:Yoric] - still alive but not very active]

Attachment: MozReview Request: Bug 1153198 - Remove accesskey for disabling add-onw;r=blassey