Windows XP uses Windows 8 style icons in toolbar

RESOLVED FIXED in Firefox 40

Status

()

Firefox
Theme
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ntim, Assigned: dao)

Tracking

({regression})

unspecified
Firefox 40
All
Windows XP
regression
Points:
1
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8590800 [details]
Screenshot

It seems like the Windows 8 toolbar sprite is being used on XP.

I suspect bug 1147702 regressed this.
(Reporter)

Updated

3 years ago
Flags: needinfo?(dao)
Keywords: regression, regressionwindow-wanted
(Reporter)

Updated

3 years ago
Blocks: 1147702
(Assignee)

Comment 1

3 years ago
I don't see how bug 1147702 could have caused this. Are you using custom DPI settings?
Flags: needinfo?(dao)
(Assignee)

Updated

3 years ago
Blocks: 706103
No longer blocks: 1147702
Keywords: regressionwindow-wanted
(Assignee)

Comment 2

3 years ago
Created attachment 8590897 [details] [diff] [review]
patch

Standard Windows XP corresponds to version number 5.1.
See https://msdn.microsoft.com/en-us/library/windows/desktop/ms724832%28v=vs.85%29.aspx
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8590897 - Flags: review?(gijskruitbosch+bugs)
(Assignee)

Updated

3 years ago
Iteration: --- → 40.1 - 13 Apr
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+

Comment 3

3 years ago
Comment on attachment 8590897 [details] [diff] [review]
patch

Review of attachment 8590897 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

(working on your other patch, almost there...)
Attachment #8590897 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/b41185c0cf61
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
You need to log in before you can comment on or make changes to this bug.