1153276 - Have distinct IDs for the plugin crashed notification bar

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

We have this per-browser-tab notification bar for notifying the user about plugin crashes if the plugin is too small to show the crash UI (or is invisible).

The problem with that is that there is no way of distinguishing (besides, from what I can tell, examining the notification string) between different plugin crashes that the notification bar belongs to.

That means that there is room for the following scenario:

1) User is on a page with Plugin A and Plugin B.
2) Plugin A is visible, and large enough to show the crash UI. Plugin B is invisible.
3) Plugin A and Plugin B crash at almost the same time.
4) Plugin B's crash gets handled first, and we show the notification bar because we notice that the plugin is invisible.
5) Plugin A's crash is handled next, and we notice that the plugin is visible, *so we send a message up to clear the notification bar*.

That means that we never see (or barely see) the crashed plugin notification bar for B, which means we don't get an opportunity to submit a crash report for it.

I suggest we have some way of distinguishing the notification bars (associating them with the plugin runID is probably the easiest way), so that we can be a little more fine-grained in the way we show and hide notification bars.

Comment 1

[BMO Automation]

Resolving as wont fix, plugin support deprecated in Firefox 85.