1153330 - Move tabs/sessions to profile

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect)

Description

[Wesley Johnston (:wesj)]

I've been needing access to the TabsManager for Clear Private data lately. I think we'll also need it in about:home for "Switch to tab". I wind up passing references to it around a lot. We do the same thing with Profile a lot. I wonder if tabs should just be a part of the Profile?

I'm thinking something like:

Profile
  - Sessions: [Session]
    -- currentSession: Session

where Session looks something like:

Session
  - subscript[int] -> Browser
  - subscript[webview] -> Browser
  - count: Int
  - selectedTab: Browser
  - restore() // For session restore?
  - writeToDisk(file: String)

Not a v1 thing, but looking for feedback.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Not a bad idea.

James will be looking to expand the Session in his current work from just storing it to an iOS provided "bundle" to saving to disk in the profile, mainly for crash restoration.

Comment 2

[Richard Newman [:rnewman]]

We also need access to your tabs for Sync: every open tab, its URL history (back stack), when it was last used, and the current page title.

That sounds like:

  Session[...] ->
    Browser
      Title
      URLs

layered into Comment 0.

I'll need this very very soon -- Monday, ideally -- for tab sync. If it's not ready by then, that's OK: we'll just have one-directional tab syncing.

This needs to be an interface in Storage, not in Client, so that Sync can read from it.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/367

Some refactoring in here that actually doesn't need to be. Just me finding my footing. Happy to take feedback if you have time, but otherwise I'll send it for review tomorrow hopefully.

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8596264 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/367

nits, comments, and questions added to ticket.

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 8596264 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/367

Back to you nick.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8596264 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/367

Comments on GH, but nothing major.  Sorry for the slow turnaround.