[Customizer] Appended SCRIPT tags are not eval'd

RESOLVED FIXED

Status

Firefox OS
Gaia
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: justindarc, Assigned: justindarc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [spark])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
STR:
1. Append Child -> SCRIPT
2. Edit SCRIPT -> Inner HTML: alert('hello');

Currently, the generated add-on code only evals *child* SCRIPT tags, but doesn't take into consideration if you are editing a SCRIPT tag directly.
(Assignee)

Updated

3 years ago
Assignee: nobody → jdarcangelo
Blocks: 1133943
Priority: -- → P1
(Assignee)

Comment 1

3 years ago
Created attachment 8590959 [details] [review]
pull-request (master)

This is actually a patch for addon-generator.
Attachment #8590959 - Flags: review?(drs)
Attachment #8590959 - Flags: review?(drs) → review+
(Assignee)

Comment 2

3 years ago
Landed on master:

https://github.com/fxos/addon-generator/commit/84ee52980789b8098aad96235d28caa427f39713
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [spark]
You need to log in before you can comment on or make changes to this bug.