Closed Bug 1153359 Opened 9 years ago Closed 9 years ago

Investigate: do we ever fail to rewrite $local?

Categories

(Android Background Services Graveyard :: Reading List Sync, defect)

Product:
Android Background Services Graveyard
Component:
Reading List Sync
Version:
Firefox 38
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1153357

People

(Reporter: rnewman, Unassigned)

Details

Some of Margaret's DB entries had "$local" in added_by. We should make sure that these are always rewritten.
The current code will always rewrite $local for items that are NEW, prior to a sync. All items start in NEW. That implies that this is an old bug. But check this out:

0            a1393f24-093d-4295-a548-636bb960df3b  1425526441902  Nightly on XT1058
0            6578f707-ad91-4050-9d50-b083e89f333d  1426739684156  $local

Those timestamps don't make sense if this is simply something that we implemented later, unless it takes Margaret 14 days to update all of her devices….
Hypothesis: an item is added to the DB in state NEW. Then Fennec modifies it, and we set it to state MODIFIED. The modified item is still fetched by getNew, because its GUID is null.

The fix here is to never transition NEW to MODIFIED.
I'm going to handle this and Bug 1153357 together.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.