1153359 - Investigate: do we ever fail to rewrite $local?

Status: RESOLVED DUPLICATE of bug 1153357

(Android Background Services Graveyard :: Reading List Sync, defect)

Description

[Richard Newman [:rnewman]]

Some of Margaret's DB entries had "$local" in added_by. We should make sure that these are always rewritten.

Comment 1

[Richard Newman [:rnewman]]

The current code will always rewrite $local for items that are NEW, prior to a sync. All items start in NEW. That implies that this is an old bug. But check this out:

0            a1393f24-093d-4295-a548-636bb960df3b  1425526441902  Nightly on XT1058
0            6578f707-ad91-4050-9d50-b083e89f333d  1426739684156  $local

Those timestamps don't make sense if this is simply something that we implemented later, unless it takes Margaret 14 days to update all of her devices….

Comment 2

[Richard Newman [:rnewman]]

Hypothesis: an item is added to the DB in state NEW. Then Fennec modifies it, and we set it to state MODIFIED. The modified item is still fetched by getNew, because its GUID is null.

The fix here is to never transition NEW to MODIFIED.

Comment 3

[Richard Newman [:rnewman]]

I'm going to handle this and Bug 1153357 together.