Open Bug 1153371 Opened 6 years ago Updated 2 years ago

Create shared place for readability content CSS styles

Categories

(Toolkit :: Reader Mode, defect, P3)

defect

Tracking

()

Tracking Status
firefox40 --- affected

People

(Reporter: Margaret, Unassigned)

References

Details

(Whiteboard: [about-reader-ui])

When creating desktop's aboutReader.css, I punted on creating a shared CSS file for shared content styles (mainly because the content style specs differed between desktop and mobile).

Ideally, we would have some shared CSS styles that we could apply to all content that we get back from readability. This would be especially useful for CSS hacks that we do to improve the output (e.g. bug 1144822).

I think it would make sense for this shared CSS file to live in the github readability repo as well.
Flags: qe-verify-
Priority: -- → P3
Whiteboard: [about-reader-ui]

:Gijs, I don't understand the issue properly. Could you please explain more?

(In reply to sonali18317 from comment #1)

:Gijs, I don't understand the issue properly. Could you please explain more?

Right now we have both https://searchfox.org/mozilla-central/source/mobile/android/themes/core/aboutReader.css and https://searchfox.org/mozilla-central/source/toolkit/themes/shared/aboutReader.css . The goal of this bug is making Android use the toolkit style file as well as the android one (right now it uses only the android one), and have the android copy only include android-specific styles, instead of duplicating things from the toolkit sheet.

Gijs, while looking at the Android version of the reader mode, I saw that there is a sepia button but the theme doesn't apply. I updated the version of my android app also.
I also noticed that there is no code for body.sepia in https://searchfox.org/mozilla-central/source/mobile/android/themes/core/aboutReader.css

Thanks for explaining the issue!

See Also: → 1534942
You need to log in before you can comment on or make changes to this bug.