1153399 - Avoid directly displaying content when unlocking device and private browsing is in the foreground

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, enhancement)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Suppose you're looking at wedding rings for your fiance. You obviously use private browsing; you forgot to close your tabs (who closes tabs?).

You are later out to dinner with your fiance, when you absentmindly unlock your phone to check your work email (who doesn't?) and BAM: WEDDING RINGS. The waiter over your shoulder notices the bright, diamondy flash from your phone and takes a peek.

"Oh, a ring? :D Congratulations!" x_x And just like that your surprise is ruined - what a surprise!

---

It could be useful to have Firefox display a privacy warning (instead of directly displaying private browsing content) when you unlock your phone with private browsing foregrounded. This warning can have a few action options: "Background Firefox", "Close all private tabs", and "Open private browsing".

An alternative easier, and perhaps more stealthy (and thus appropriate), solution: switch to normal tabs when unlocking the device. It may be good to also notify the user that they have private browsing tabs open so they're not caught off-guard later (maybe a tab counter on the private browsing icon in the tabs tray?)

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

There's a similar bug somewhere about hiding tab "previews" in the tray for the same reasons. :)

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Talked to mcomella on vidyo. 

This is more about the lock screen, and unlocking, than the tabs tray. Maybe we can take a look at this in V2.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Anthony Lam (:antlam) from comment #2)
> Hm...this sounds like a dupe of bug 1153399.
> 
> I think just killing the private browsing session is a bit aggressive. I can
> see this causing a lot of problems since there are many reasons why the user
> could have ended up putting the device to "sleep".
> 
> If the issue we're focusing on is "As a user, I don't want other people to
> see my private tabs", perhaps we should focus on better serving the use
> cases for when the user IS using Firefox first. For example, hiding previews
> in the private tabs tray? or maybe even offering to close all private tabs
> when they switch back to the normal tabs tray?

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.