Solaris is failing to build with this error: "/builds/bstell/1mojo/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp", line 4636: Warning: Too many characters in character constant '\".so\"'. "/builds/bstell/1mojo/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp", line 4636: Error: Badly formed expression. 1 Error(s) and 2 Warning(s) detected. If I add this hack to nsPluginHostImpl.cpp it will build: 163 #undef MOZ_DLL_SUFFIX 164 #define MOZ_DLL_SUFFIX ".so"
bstell: Which configure-flags do you use ?
This is a known problem but I can't seem to find another bug report on it. The Forte compiler creates a SunWS_cache dir and gets confused when certain files use defines on the commandline with quotes in them, ie -DMOZ_DLL_SUFFIX=\".so\" . We've hit this on the tinderbox quite a bit so I added a hack to just remove that cache dir at the beginning of the tinderbox cycle.
Greg, wanna take a look at comment #2, please ?
You need to delete the .WS_cache directory (or whatever it's called). Depend builds are not reliable with the Sun WS compiler since its cache files are buggy.
Assignee: asa → seawood
Component: Browser-General → Build Config
QA Contact: doronr → granrose
Hrm. We could patch this case with a solaris && !GNU_CC define but there's no guarantee that the problem wouldn't crop up at any of the other 20+ places that MOZ_DLL_SUFFIX is used or any other define that uses "s on the cmdline. The other option would be to switch to using a mozconfig.h include file instead of putting the defines on the cmdline for non-gcc compilers. This would be the same as the proposed solution for bug 80812. It's clearly a compiler bug so I should mark it invalid. I'm going to push it out instead.
Summary: solaris fails to build → Forte -Dfoo=\"foo\" bug needs workaround
Target Milestone: mozilla0.9.7 → mozilla1.1
To the best of my knowledge I have not changed my solaris build settings. When I get into the office I will report more info.
cls: Could to try to apply the follwing compiler patches: -- snip -- Patch-ID# 111678-05 Synopsis: Compiler Common 6.2: Patch Forte Developer 6 update 2, C++ F77 F95 Patch-ID# 111679-03 Synopsis: C 5.3: Patch for Forte Developer 6 update 2 C compiler Patch-ID# 111683-03 Synopsis: Forte Developer 6 update 2: Patch for Debugger Patch-ID# 111685-03 Synopsis: C++ 5.3: Patch for Forte Developer 6 update 2 C++ compiler Patch-ID# 111690-03 Synopsis: F90 6.2: Patch for Forte Developer 6 update 2 Fortran 95 6.2 compiler Patch-ID# 111691-02 Synopsis: F77 5.3: Patch for Forte Developer 6 update 2 FORTRAN 77 5.3 compiler Patch-ID# 111692-01 Synopsis: TeamWare 6.02: Patch for Forte TeamWare 6.02 -- snip --
Created attachment 63286 [details] bstell's .bashrc file I always build under a bash shell; for reference here is my $HOME/.bashrc file
Created attachment 63287 [details] solaris env file I always source this file before building on solaris
*** Bug 146467 has been marked as a duplicate of this bug. ***
Margaret Chan: Is there a SunSolve bug id for this issue ?
Summary: Forte -Dfoo=\"foo\" bug needs workaround → Sun Workshop/Forte -Dfoo=\"foo\" bug needs workaround
Nebiros has been doing a depend build for over a month without a problem and without the tinderbox hack. I think the last set of patches for WS6U2 fixed the problem (or it could just be that we stopped using MOZ_DLL_SUFFIX).
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → INVALID
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.