Closed Bug 1153506 Opened 8 years ago Closed 5 years ago

The MAFF extension fails under e10s on the NIghtly channel (fedora 21)

Categories

(Firefox :: Extension Compatibility, defect)

Product:
Firefox
Component:
Extension Compatibility
Version:
40 Branch
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: liam, Unassigned)

References

Details

(Whiteboard: triaged)

Attachments

(2 files)

dialog when using maff addon to open file in nightly, 20150616.
187.15 KB, image/png
Details
What the failed maff saved file looks like when opened in firefox 38
43.36 KB, image/png
Details 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150410030204

Steps to reproduce:

Installed http://maf.mozdev.org/. Attempted to save http://www.cyberciti.biz/tips/top-linux-monitoring-tools.html. Resultant maff contained two files: an empty index.html and an rdf file that just pointed the site.
In the same session I opened a non-e10s window, and the page was save correctly.


Actual results:

No snapshot was made of page.


Expected results:

The maff should've contained all page assets.
Blocks: e10s-addons
Component: Untriaged → Extension Compatibility
Console logs many, many "unsafe CPOW usage", and one exception.

[Exception... "It's illegal to pass a CPOW to native code arg 0 [nsIDocumentEncoder.init]"  nsresult: "0x80570036 (NS_ERROR_XPC_CANT_PASS_CPOW_TO_NATIVE)"  location: "JS frame :: chrome://maf/content/saving/exactPersistParsedJobObject.js :: ExactPersistParsedJob.prototype._executeStart :: line 801"  data: no]
I am also seeing this error.  I didn't even realize that it was happening, until I found another error with the maff plugin.

When I tried to do a bifurcation, I couldn't find a working version of maff add-on in nightly as far back as 2010.

However, if I use firefox 38, as provided from the Fedora 21 repositories, saving and reading work fine, with the same version of the add-on that fails in nightly.

I'll attach a picture of the dialogue that opens when I try to read a saved maff web page in nightly.

What a mess.  This means that any pages I've saved with nightly are useless.  And that I can no longer use nightly as my default browser.
In addition to not saving maff pages properly, when trying to view saved maff pages this dialog comes up.

This is in version 41 of nightly.  And the initial dialog when opening the browser says that this addon is compatible with nightly.
The addon is
mozilla archive format 3.1.0.1-signed
This shows what a page saved using maff in nightly looks like when opened with firefox 38.
A little more research shows that nightly always has "Options > General > Startup > Enable multi-process Nightly" checked, and this by default enables e10s.

That the mozilla archive format addon isn't working implies that it is accessing web content directly.  Thus, when e10s becomes the default later this year, then this add on will stop working until it is converted to use frame scripts as described at 
https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox

Not directly the fault of nightly, a casualty of progress.
Related to bug 1047789.
Yes, indeedy.  Thanks for pointing this out.  And your reminder, brought to mind a couple of instances where, lately, nightly saved the maff image file properly, but wouldn't open it again.  The files it saves open OK in the Fedora version of the production firefox 42.02.  

This plugin is valuable.  Things that disappear, or I don't remember where I found them, or I can't quite remember what the page said, this solves that.  And when I don't need the reference anymore, easily deleted.

Given how fast internet tech changes, this will probably go away at some point.  I suppose I could get by with screen shots if I had to, as long as it was as convenient as this.
(In reply to stan from comment #8)
> Yes, indeedy.  Thanks for pointing this out.  And your reminder, brought to
> mind a couple of instances where, lately, nightly saved the maff image file
> properly, but wouldn't open it again.  The files it saves open OK in the
> Fedora version of the production firefox 42.02.  
> 
> This plugin is valuable.  Things that disappear, or I don't remember where I
> found them, or I can't quite remember what the page said, this solves that. 
> And when I don't need the reference anymore, easily deleted.
> 
> Given how fast internet tech changes, this will probably go away at some
> point.  I suppose I could get by with screen shots if I had to, as long as
> it was as convenient as this.

Some of your use-case may be solved in the future. Can't say much as I'm under NDA.
shell check for testing 170,000 users....
Flags: needinfo?(sescalante)
(In reply to Jerod Lycett from comment #9)
> (In reply to stan from comment #8)
> > Yes, indeedy.  Thanks for pointing this out.  And your reminder, brought to
> > mind a couple of instances where, lately, nightly saved the maff image file
> > properly, but wouldn't open it again.  The files it saves open OK in the
> > Fedora version of the production firefox 42.02.  
> > 
> > This plugin is valuable.  Things that disappear, or I don't remember where I
> > found them, or I can't quite remember what the page said, this solves that. 
> > And when I don't need the reference anymore, easily deleted.
> > 
> > Given how fast internet tech changes, this will probably go away at some
> > point.  I suppose I could get by with screen shots if I had to, as long as
> > it was as convenient as this.
> 
> Some of your use-case may be solved in the future. Can't say much as I'm
> under NDA.

As it's been about 10 months since you wrote the above, can you now say anything more?

@sescalante@mozilla.com

what info do you need...assuming you're not a bot:)
Flags: needinfo?(sescalante)
Whiteboard: triaged
The maff plugin continued to work via options in the File menu.  That is, it lost the short cut keys that had previously enabled it.

However, now that I have moved to nightly 53, there is no more maff.  The file menu only shows "Save Page As ..." for an option.  And that only allows saving the raw page, rather than a compressed page.

And all my previously saved maff pages are no longer available:  Dialog saying,
"You have chosen to open ...
Would you like to save this file?"

Is this a bug, or planned obsolescence?
(In reply to Jerod Lycett from comment #9)
> (In reply to stan from comment #8)
> > Yes, indeedy.  Thanks for pointing this out.  And your reminder, brought to
> > mind a couple of instances where, lately, nightly saved the maff image file
> > properly, but wouldn't open it again.  The files it saves open OK in the
> > Fedora version of the production firefox 42.02.  
> > 
> > This plugin is valuable.  Things that disappear, or I don't remember where I
> > found them, or I can't quite remember what the page said, this solves that. 
> > And when I don't need the reference anymore, easily deleted.
> > 
> > Given how fast internet tech changes, this will probably go away at some
> > point.  I suppose I could get by with screen shots if I had to, as long as
> > it was as convenient as this.
> 
> Some of your use-case may be solved in the future. Can't say much as I'm
> under NDA.(In reply to Jerod Lycett from comment #9)
> (In reply to stan from comment #8)
> > Yes, indeedy.  Thanks for pointing this out.  And your reminder, brought to
> > mind a couple of instances where, lately, nightly saved the maff image file
> > properly, but wouldn't open it again.  The files it saves open OK in the
> > Fedora version of the production firefox 42.02.  
> > 
> > This plugin is valuable.  Things that disappear, or I don't remember where I
> > found them, or I can't quite remember what the page said, this solves that. 
> > And when I don't need the reference anymore, easily deleted.
> > 
> > Given how fast internet tech changes, this will probably go away at some
> > point.  I suppose I could get by with screen shots if I had to, as long as
> > it was as convenient as this.
> 
> Some of your use-case may be solved in the future. Can't say much as I'm
> under NDA.

It has been about 15 months. Has that NDA expired yet?
This is a pretty important plugin,and if webextensions are not yet capable of supporting this functionality we need to know.
Since yesterday's nightly, 20170228, the maff options have returned to the file menu, and they work.  Thank you.
I spoke too soon.  While it is true that the maff options have returned to the file menu, that is with e10s turned off.  When I turn it on, which I did for testing another issue, the maff save options are gone from the file menu.  :-(
This is as alive on Firefox 52 (on Fedora) as ever before.
(In reply to Jerod Lycett from comment #9)
> (In reply to stan from comment #8)
> > Yes, indeedy.  Thanks for pointing this out.  And your reminder, brought to
> > mind a couple of instances where, lately, nightly saved the maff image file
> > properly, but wouldn't open it again.  The files it saves open OK in the
> > Fedora version of the production firefox 42.02.  
> > 
> > This plugin is valuable.  Things that disappear, or I don't remember where I
> > found them, or I can't quite remember what the page said, this solves that. 
> > And when I don't need the reference anymore, easily deleted.
> > 
> > Given how fast internet tech changes, this will probably go away at some
> > point.  I suppose I could get by with screen shots if I had to, as long as
> > it was as convenient as this.
> 
> Some of your use-case may be solved in the future. Can't say much as I'm
> under NDA.

You still around?
This remains an issue.
If you NDA hasn't expired yet, you may have signed something else altogther.
This is about a legacy extension which is no longer valid in Firefox Quantum, closing.
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.