Closed
Bug 1153534
Opened 10 years ago
Closed 10 years ago
Remove old currSize parameter deletion for Loop's rooms now the loop-server no longer supplies it
Categories
(Hello (Loop) :: Client, defect, P3)
Hello (Loop)
Client
Tracking
(firefox40 fixed)
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [tech-debt])
Attachments
(1 file)
|
2.70 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
At some stage the loop-server used to provide a currSize parameter that was removed fairly immediately, but we had deletion of it in our code.
Since the parameter is long since gone, I think we can safely remove the deletion of it and the instances of it in our tests.
I also need this for bug 1142522 as I'm trying to fix some of the tests there and its getting in the way.
|
Assignee | |
Comment 1•10 years ago
|
||
Simple patch to remove the old references.
Attachment #8591217 -
Flags: review?(mdeboer)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8591217 [details] [diff] [review]
Remove old currSize parameter deletion now the loop-server no longer supplies it.
Review of attachment 8591217 [details] [diff] [review]:
-----------------------------------------------------------------
Agreed.
Attachment #8591217 -
Flags: review?(mdeboer) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Target Milestone: --- → mozilla40
|
|
Assignee | |
Updated•10 years ago
|
Flags: qe-verify-
Flags: firefox-backlog+
You need to log in
before you can comment on or make changes to this bug.
Description
•