Remove old currSize parameter deletion for Loop's rooms now the loop-server no longer supplies it

RESOLVED FIXED in Firefox 40

Status

Hello (Loop)
Client
P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla40
Points:
1
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: [tech-debt])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
At some stage the loop-server used to provide a currSize parameter that was removed fairly immediately, but we had deletion of it in our code.

Since the parameter is long since gone, I think we can safely remove the deletion of it and the instances of it in our tests.

I also need this for bug 1142522 as I'm trying to fix some of the tests there and its getting in the way.
(Assignee)

Comment 1

3 years ago
Created attachment 8591217 [details] [diff] [review]
Remove old currSize parameter deletion now the loop-server no longer supplies it.

Simple patch to remove the old references.
Attachment #8591217 - Flags: review?(mdeboer)
Comment on attachment 8591217 [details] [diff] [review]
Remove old currSize parameter deletion now the loop-server no longer supplies it.

Review of attachment 8591217 [details] [diff] [review]:
-----------------------------------------------------------------

Agreed.
Attachment #8591217 - Flags: review?(mdeboer) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/3cbd2df9e73d
Target Milestone: --- → mozilla40
(Assignee)

Updated

3 years ago
Flags: qe-verify-
Flags: firefox-backlog+
https://hg.mozilla.org/mozilla-central/rev/3cbd2df9e73d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.